Nettoyage de quelques settings obsolètes (#78230) #70
|
@ -152,7 +152,6 @@ default_settings = dict(
|
|||
A2_REGISTRATION_REALM=Setting(
|
||||
default=None, definition='Default realm to assign to self-registrated users'
|
||||
),
|
||||
A2_REGISTRATION_GROUPS=Setting(default=(), definition='Default groups for self-registered users'),
|
||||
tnoel marked this conversation as resolved
Outdated
|
||||
A2_PROFILE_FIELDS=Setting(default=(), definition='Fields to show to the user in the profile page'),
|
||||
A2_REGISTRATION_FIELDS=Setting(
|
||||
default=(), definition='Fields from the user model that must appear on the registration form'
|
||||
|
|
|
@ -18,7 +18,7 @@ import re
|
|||
|
||||
from django.conf import settings
|
||||
from django.contrib.auth import get_user_model
|
||||
from django.contrib.auth.models import BaseUserManager, Group
|
||||
from django.contrib.auth.models import BaseUserManager
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.core.validators import RegexValidator
|
||||
from django.forms import Form
|
||||
|
@ -163,14 +163,7 @@ class RegistrationCompletionFormNoPassword(profile_forms.BaseUserForm):
|
|||
def save(self, commit=True):
|
||||
self.instance.set_email_verified(True, source='registration')
|
||||
self.instance.is_active = True
|
||||
user = super().save(commit=commit)
|
||||
if commit and app_settings.A2_REGISTRATION_GROUPS:
|
||||
groups = []
|
||||
for name in app_settings.A2_REGISTRATION_GROUPS:
|
||||
group, dummy = Group.objects.get_or_create(name=name)
|
||||
groups.append(group)
|
||||
user.groups = groups
|
||||
return user
|
||||
return super().save(commit=commit)
|
||||
|
||||
|
||||
class RegistrationCompletionForm(RegistrationCompletionFormNoPassword):
|
||||
|
|
Loading…
Reference in New Issue
Pour le SHOW_LAST_CHAR ça ne pose pas de problème de le supprimer (ça va rien complétement casser) mais pour ce settings REGISTRATION_GROUPS on pourrait penser que des Authentic que nous ne suivons/gérons pas utilisent en fait cette affaire, et ça pourrait casser le fonctionnement...?
On est vraiment sur du très très vieux code qui date d'avant l'utilisation du modèle RBAC, on voit que le code ajoute des Group et pas des Role, c'est vraiment un retrait complètement safe.
Réponse acceptée !