entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 33 Releases Activity

Personnalisation de la page “Mon compte” en fonction du service connecté (#75142) #50

Merged
pmarillonnet merged 1 commits from wip/75142-accounts-default-service-customization into main 2023-06-13 11:49:11 +02:00
Conversation 2 Commits 1 Files Changed 5 +151 -12
pmarillonnet commented 2023-05-04 11:48:03 +02:00
Owner
Copy Link
No description provided.
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from d27e774745 to 36cd86adb2 2023-05-04 14:38:18 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 36cd86adb2 to 2c9b1a9430 2023-05-15 16:56:07 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 2c9b1a9430 to a3017cb303 2023-05-16 09:16:18 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from a3017cb303 to 56b516e19e 2023-05-16 10:44:10 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 56b516e19e to 130ba4bbe8 2023-05-16 16:24:08 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 130ba4bbe8 to 199d89efe8 2023-05-16 16:47:37 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 199d89efe8 to f4617c97d5 2023-05-16 17:34:24 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from f4617c97d5 to de44901c33 2023-05-17 09:08:14 +02:00 Compare
pmarillonnet changed title from WIP: place service in context processor (#75142) to Personnalisation de la page “Mon compte” en fonction du service connecté (#75142) 2023-05-17 09:11:54 +02:00
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from de44901c33 to 68d429cd44 2023-05-17 09:22:22 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 68d429cd44 to 761b82f4f6 2023-05-17 09:34:54 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 761b82f4f6 to 6ad2e198f4 2023-05-17 11:49:32 +02:00 Compare
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 6ad2e198f4 to 5edb6ab335 2023-05-22 14:52:51 +02:00 Compare
pmarillonnet commented 2023-05-22 15:05:39 +02:00
Author
Owner
Copy Link

J’ai retiré la dépendance à publik-django-templatetags (elle s’articulait autour de #77644, qui n’est plus d’actualité), ça reste bon pour relecture.

J’ai retiré la dépendance à publik-django-templatetags (elle s’articulait autour de #77644, qui n’est plus d’actualité), ça reste bon pour relecture.
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 5edb6ab335 to d667297da9 2023-05-23 09:04:46 +02:00 Compare
pmarillonnet reviewed 2023-05-31 11:03:53 +02:00
src/authentic2/templates/authentic2/accounts.html Outdated
@ -15,0 +40,4 @@
<a href="{% firstof home_url generic_service_home_url %}">
{% endif %}
<img src="{{ logo_url }}" alt="{{ name }}" class="a2-service-information--logo" />
{% if service.home_url %}
pmarillonnet commented 2023-05-31 11:03:53 +02:00
Author
Owner
Copy Link

Il manque le or generic_service_home_url ici dans la condition, je vais corriger.
En l’état les tests ne cassent pas parce que django détecte l’absence de balise fermante et l’ajoute.

Il manque le `or generic_service_home_url` ici dans la condition, je vais corriger. En l’état les tests ne cassent pas parce que django détecte l’absence de balise fermante et l’ajoute.
pmarillonnet commented 2023-06-01 14:05:46 +02:00
Author
Owner
Copy Link

(C’est corrigé.)

(C’est corrigé.)
tjund commented 2023-05-31 12:07:17 +02:00
Owner
Copy Link

Moi rien à dire côté HTML, je vois des modifications à apporter, mais ce sera sur le template PBT déjà validé (donc autre PR). Je laisse un autre dev valider le code django.

Moi rien à dire côté HTML, je vois des modifications à apporter, mais ce sera sur le template PBT déjà validé (donc autre PR). Je laisse un autre dev valider le code django.
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from d667297da9 to 5e7f31f42b 2023-06-01 14:05:23 +02:00 Compare
vdeniaud approved these changes 2023-06-13 11:20:44 +02:00
pmarillonnet force-pushed wip/75142-accounts-default-service-customization from 5e7f31f42b to bebb6786ca 2023-06-13 11:29:00 +02:00 Compare
pmarillonnet merged commit bebb6786ca into main 2023-06-13 11:49:11 +02:00
pmarillonnet deleted branch wip/75142-accounts-default-service-customization 2023-06-13 11:49:11 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
vdeniaud
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/authentic#50
No description provided.
Delete Branch "wip/75142-accounts-default-service-customization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?