entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 33 Releases Activity

auth_oidc: provide a less scary displayed error message (#73669) #39

Merged
pmarillonnet merged 1 commits from wip/73669-auth-oidc-simpler-error-messages into main 2023-04-19 13:31:32 +02:00
Conversation 0 Commits 1 Files Changed 2 +45 -6
pmarillonnet commented 2023-04-17 09:54:30 +02:00
Owner
Copy Link
The user simply gets a generic error message.  The more detailed
description gets logged and appears as a django debug-level message.
The user simply gets a generic error message. The more detailed description gets logged and appears as a django debug-level message.
pmarillonnet force-pushed wip/73669-auth-oidc-simpler-error-messages from 8a7cbe2408 to e8f356f686 2023-04-19 10:59:52 +02:00 Compare
pmarillonnet changed title from WIP: auth_oidc: provide a less scary displayed error message (#73669) to auth_oidc: provide a less scary displayed error message (#73669) 2023-04-19 11:00:22 +02:00
bdauvergne approved these changes 2023-04-19 11:27:19 +02:00
tests/test_auth_oidc.py Outdated
@ -1183,0 +1195,4 @@
assert 'denied by you or the identity provider' not in caplog.records[-1].message
assert 'some OP technical error message' in caplog.records[-1].message
with override_settings(MESSAGE_LEVEL=message_constants.DEBUG):
bdauvergne commented 2023-04-19 11:27:15 +02:00
Owner
Copy Link

Je découvre ce setting, je crois que c'est la première fois que je vois l'utilisation d'un message Django de niveau DEBUG. C'est sympa mais ça risque de ne pas être très utilisé voir jamais.

Je découvre ce setting, je crois que c'est la première fois que je vois l'utilisation d'un message Django de niveau DEBUG. C'est sympa mais ça risque de ne pas être très utilisé voir jamais.
pmarillonnet force-pushed wip/73669-auth-oidc-simpler-error-messages from e8f356f686 to 4ea4a63098 2023-04-19 13:03:58 +02:00 Compare
pmarillonnet changed target branch from wip/72538-auth-oidc-prompt-none-error to main 2023-04-19 13:04:15 +02:00
pmarillonnet merged commit 4ea4a63098 into main 2023-04-19 13:31:32 +02:00
pmarillonnet deleted branch wip/73669-auth-oidc-simpler-error-messages 2023-04-19 13:31:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
bdauvergne
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/authentic#39
No description provided.
Delete Branch "wip/73669-auth-oidc-simpler-error-messages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?