entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 32 Releases Activity

phone-authn: on registration, inform user of existing duplicate (#88163) #286

Merged
pmarillonnet merged 1 commits from wip/88163-phone-authn-registration-existing-account-misleading-ui into main 2024-04-29 09:51:50 +02:00
Conversation 1 Commits 1 Files Changed 2 +89
pmarillonnet commented 2024-03-26 09:56:11 +01:00
Owner
Copy Link
No description provided.
pmarillonnet added 1 commit 2024-03-26 09:56:11 +01:00
gitea/authentic/pipeline/head There was a failure building this commit Details
72f44b22c6 phone-authn: on registration, inform user of existing duplicate (#88163)
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from 72f44b22c6 to dca50d409d 2024-03-26 10:01:36 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from dca50d409d to 17ea07f5f2 2024-03-26 10:11:46 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from 17ea07f5f2 to 74f8a0e554 2024-03-26 10:25:43 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from 74f8a0e554 to d6500860fc 2024-03-26 10:26:50 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from d6500860fc to a91cc5e502 2024-03-26 10:52:39 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from a91cc5e502 to e33986a44b 2024-03-26 11:06:46 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from e33986a44b to 8f7c89faab 2024-03-26 11:21:12 +01:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from 8f7c89faab to 448d3f16e6 2024-03-26 11:31:52 +01:00 Compare
pmarillonnet changed title from WIP: phone-authn: on registration, inform user of existing duplicate (#88163) to phone-authn: on registration, inform user of existing duplicate (#88163) 2024-03-26 12:07:10 +01:00
smihai approved these changes 2024-04-24 15:32:06 +02:00
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from 448d3f16e6 to c69ac3827a 2024-04-24 15:38:22 +02:00 Compare
pmarillonnet commented 2024-04-24 15:39:04 +02:00
Author
Owner
Copy Link

(On m’a signalé en privé une chaîne éclatée en plusieurs parties sur une même ligne dans les tests, reliquats d’un coup de black pas judicieux, c’est corrigé.)

(On m’a signalé en privé une chaîne éclatée en plusieurs parties sur une même ligne dans les tests, reliquats d’un coup de `black` pas judicieux, c’est corrigé.)
fpeters reviewed 2024-04-26 07:42:55 +02:00
src/authentic2/views.py Outdated
@ -1939,0 +1941,4 @@
):
# no creation because of ou identifier uniqueness
message = _(
"You've been logged in with your account already existing within ou {ou} for this identifier."
fpeters commented 2024-04-26 07:42:55 +02:00
Owner
Copy Link

C'est déjà validé mais je note quand même :

"ou" ça ne va pas parler à l'usager; je serais même à penser que le message à l'usager pourrait être le même dans les deux situations, plutôt qu'essayer de lui passer la subtilité.

Dessous on a "your already-existing account" vs ici "your account already existing".

C'est déjà validé mais je note quand même : "ou" ça ne va pas parler à l'usager; je serais même à penser que le message à l'usager pourrait être le même dans les deux situations, plutôt qu'essayer de lui passer la subtilité. Dessous on a "your already-existing account" vs ici "your account already existing".
pmarillonnet commented 2024-04-29 09:32:40 +02:00
Author
Owner
Copy Link

Merci, en effet, je corrige et mets le même message dans les deux cas.

Merci, en effet, je corrige et mets le même message dans les deux cas.
pmarillonnet added 1 commit 2024-04-29 09:37:18 +02:00
gitea/authentic/pipeline/head There was a failure building this commit Details
4533e22bea [wip] do not disambiguate OU-uniqueness in front info
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from 4533e22bea to ca326f4285 2024-04-29 09:40:51 +02:00 Compare
pmarillonnet force-pushed wip/88163-phone-authn-registration-existing-account-misleading-ui from ca326f4285 to 7f03e02e06 2024-04-29 09:45:57 +02:00 Compare
pmarillonnet merged commit 7f03e02e06 into main 2024-04-29 09:51:50 +02:00
pmarillonnet deleted branch wip/88163-phone-authn-registration-existing-account-misleading-ui 2024-04-29 09:51:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
smihai
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/authentic#286
No description provided.
Delete Branch "wip/88163-phone-authn-registration-existing-account-misleading-ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?