entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 35 Releases Activity

api: remove deprecated statistics from API listing (#86177) #247

Merged
yweber merged 1 commits from wip/86177-do-not-expose-deprecated-stats into main 2024-01-30 15:08:06 +01:00
Conversation 0 Commits 1 Files Changed 2 +39 -62
yweber commented 2024-01-29 15:33:27 +01:00
Owner
Copy Link
No description provided.
yweber force-pushed wip/86177-do-not-expose-deprecated-stats from aea2095421 to 292665804a 2024-01-29 15:35:30 +01:00 Compare
yweber changed title from WIP: api: remove deprecated statistics from API listing (#86177) to api: remove deprecated statistics from API listing (#86177) 2024-01-29 15:44:11 +01:00
vdeniaud requested changes 2024-01-29 16:06:46 +01:00
src/authentic2/api_views.py Outdated
@ -1642,6 +1642,8 @@ class StatisticsAPI(ViewSet):
filters.append(group_by_filter)
deprecated = False
else:
if 'deprecated' not in request.query_params:
vdeniaud commented 2024-01-29 16:01:30 +01:00
Owner
Copy Link

Pour moi on se passer de ce nouveau paramètre, je ne vois pas d'usage où il serait utile (d'autant plus que l'API pour lister les stats est commune à toutes les briques, on ne peut pas passer un paramètre à une seule facilement)

Pour moi on se passer de ce nouveau paramètre, je ne vois pas d'usage où il serait utile (d'autant plus que l'API pour lister les stats est commune à toutes les briques, on ne peut pas passer un paramètre à une seule facilement)
yweber marked this conversation as resolved
yweber force-pushed wip/86177-do-not-expose-deprecated-stats from 292665804a to f5ff1124e4 2024-01-30 09:19:23 +01:00 Compare
yweber force-pushed wip/86177-do-not-expose-deprecated-stats from f5ff1124e4 to 5eef3e55a9 2024-01-30 09:31:37 +01:00 Compare
yweber requested review from vdeniaud 2024-01-30 09:31:53 +01:00
vdeniaud approved these changes 2024-01-30 10:16:39 +01:00
vdeniaud left a comment
Owner
Copy Link

2 petites remarques à prendre en compte et c'est bon pour moi :)

2 petites remarques à prendre en compte et c'est bon pour moi :)
src/authentic2/api_views.py Outdated
@ -1644,2 +1644,3 @@
else:
deprecated = True
continue # stop listing deprecated statistics (#86177)
# deprecated = True
vdeniaud commented 2024-01-30 10:16:24 +01:00
Owner
Copy Link

On peut enlever cette ligne commentée

On peut enlever cette ligne commentée
yweber marked this conversation as resolved
tests/api/test_statistics.py Outdated
@ -31,3 +31,3 @@
def test_api_statistics_list(app, admin):
def test_api_statistics_list_all(app, admin):
vdeniaud commented 2024-01-30 10:16:04 +01:00
Owner
Copy Link

Plus besoin de renommer le test

Plus besoin de renommer le test
yweber marked this conversation as resolved
yweber force-pushed wip/86177-do-not-expose-deprecated-stats from 5eef3e55a9 to 59122b4d1f 2024-01-30 15:00:27 +01:00 Compare
yweber force-pushed wip/86177-do-not-expose-deprecated-stats from 59122b4d1f to d7bfac4ed5 2024-01-30 15:00:48 +01:00 Compare
yweber merged commit d7bfac4ed5 into main 2024-01-30 15:08:06 +01:00
yweber deleted branch wip/86177-do-not-expose-deprecated-stats 2024-01-30 15:08:06 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
vdeniaud
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/authentic#247
No description provided.
Delete Branch "wip/86177-do-not-expose-deprecated-stats"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?