entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 35 Releases Activity

Retrait de la colonne User.phone (#81282) #129

Open
pmarillonnet wants to merge 2 commits from wip/81282-remove-user-phone-column into main
pull from: wip/81282-remove-user-phone-column
merge into: entrouvert:main
Conversation 0 Commits 2 Files Changed 15 +139 -39
pmarillonnet commented 2023-09-18 10:11:41 +02:00
Owner
Copy Link
No description provided.
pmarillonnet added 2 commits 2023-09-18 10:11:42 +02:00
gitea/authentic/pipeline/head This commit looks good Details
0a6b694c7b custom_user: delete deprecated model phone field (#81282)
pmarillonnet force-pushed wip/81282-remove-user-phone-column from 0a6b694c7b to 2754ef9dc4 2023-09-27 09:49:15 +02:00 Compare
pmarillonnet force-pushed wip/81282-remove-user-phone-column from 2754ef9dc4 to a14305a56e 2023-09-27 10:12:33 +02:00 Compare
pmarillonnet force-pushed wip/81282-remove-user-phone-column from a14305a56e to 37e2011a17 2023-09-27 10:21:06 +02:00 Compare
bdauvergne requested changes 2023-12-21 11:57:36 +01:00
bdauvergne left a comment
Owner
Copy Link

Je ne suis pas chaud bouillant, je ne sais toujours pas où partent les données actuellement, je verrai plutôt un premier patch pour renommer phone en old_phone et s'assurer qu'il n'apparaisse nul part dans les écrans et ne bloque rien. Le retrait de l'homonymie permettra déjà d'y voir plus clair sans jeter des données à la poubelle.

Je ne suis pas chaud bouillant, je ne sais toujours pas où partent les données actuellement, je verrai plutôt un premier patch pour renommer phone en old_phone et s'assurer qu'il n'apparaisse nul part dans les écrans et ne bloque rien. Le retrait de l'homonymie permettra déjà d'y voir plus clair sans jeter des données à la poubelle.
All checks were successful
gitea/authentic/pipeline/head This commit looks good
Details
This pull request has changes conflicting with the target branch.
  • tests/api/test_all.py
  • tests/test_migrations.py
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b wip/81282-remove-user-phone-column main
git pull origin wip/81282-remove-user-phone-column

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff wip/81282-remove-user-phone-column
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
bdauvergne
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/authentic#129
No description provided.
Delete Branch "wip/81282-remove-user-phone-column"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?