entrouvert
/
bijoe
17
0
Fork 0
Code Issues Pull Requests Releases Activity

schemas: do not clober value variable (#40484)

This commit is contained in:
Benjamin Dauvergne 2020-03-06 10:27:54 +01:00
parent df69adaf1a
commit 7731e183fd
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bijoe/schemas.py
View File

@ -297,19 +297,19 @@ class Dimension(Base):
is_none = None in filter_values
filter_values = [v for v in filter_values if v is not None]
values = []
for value in filter_values:
for filter_value in filter_values:
try:
if self.type == 'string':
value = str(value)
filter_value = str(filter_value)
elif self.type == 'integer':
value = int(value)
filter_value = int(filter_value)
elif self.type == 'bool':
value = bool(value)
filter_value = bool(filter_value)
else:
raise NotImplementedError
except (ValueError, TypeError):
continue
values.append(value)
values.append(filter_value)
expressions = []
if values:
s = ', '.join(['%s'] * len(values))

2
tests/test_schema1.py
View File

@ -334,7 +334,7 @@ def test_filter_type_mismatch(schema1, app, admin):
'string': [1],
}
})
assert visu.json_data() == [{'coords': [], 'measures': [{'value': 17}]}]
assert visu.json_data() == [{'coords': [], 'measures': [{'value': 0}]}]
def test_empty_filter(schema1, app, admin):