From 7731e183fd88d6f15ffd5f0ee8594ae764330267 Mon Sep 17 00:00:00 2001
From: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Fri, 6 Mar 2020 10:27:54 +0100
Subject: [PATCH] schemas: do not clober value variable (#40484)

---
 bijoe/schemas.py      | 10 +++++-----
 tests/test_schema1.py |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/bijoe/schemas.py b/bijoe/schemas.py
index 101c920..273dcb9 100644
--- a/bijoe/schemas.py
+++ b/bijoe/schemas.py
@@ -297,19 +297,19 @@ class Dimension(Base):
             is_none = None in filter_values
             filter_values = [v for v in filter_values if v is not None]
             values = []
-            for value in filter_values:
+            for filter_value in filter_values:
                 try:
                     if self.type == 'string':
-                        value = str(value)
+                        filter_value = str(filter_value)
                     elif self.type == 'integer':
-                        value = int(value)
+                        filter_value = int(filter_value)
                     elif self.type == 'bool':
-                        value = bool(value)
+                        filter_value = bool(filter_value)
                     else:
                         raise NotImplementedError
                 except (ValueError, TypeError):
                     continue
-                values.append(value)
+                values.append(filter_value)
             expressions = []
             if values:
                 s = ', '.join(['%s'] * len(values))
diff --git a/tests/test_schema1.py b/tests/test_schema1.py
index 06dde0f..be74a81 100644
--- a/tests/test_schema1.py
+++ b/tests/test_schema1.py
@@ -334,7 +334,7 @@ def test_filter_type_mismatch(schema1, app, admin):
             'string': [1],
         }
     })
-    assert visu.json_data() == [{'coords': [], 'measures': [{'value': 17}]}]
+    assert visu.json_data() == [{'coords': [], 'measures': [{'value': 0}]}]
 
 
 def test_empty_filter(schema1, app, admin):