backoffice: display drafts stats (#72542)

tests/admin_pages/test_form.py

@@ -4739,30 +4739,41 @@ def test_admin_form_inspect_drafts(pub):
     formdata.store()
 
     resp = app.get('/backoffice/forms/%s/inspect' % formdef.id)
-    assert resp.pyquery('div#inspect-drafts tr#0').length == 1
-    assert resp.pyquery('div#inspect-drafts tr#0 td.label').text() == '1st page'
-    assert resp.pyquery('div#inspect-drafts tr#0 td.percent').text() == '20.0%'
-    assert resp.pyquery('div#inspect-drafts tr#0 td.total').text() == '(1/5)'
+    assert resp.pyquery('#inspect-drafts p')[0].text == 'Statistics on drafts by page.'
+    assert (
+        resp.pyquery('#inspect-drafts p')[1].text
+        == 'Lifespan of drafts (in days): %s.' % formdef.get_drafts_lifespan()
+    )
 
-    assert resp.pyquery('div#inspect-drafts tr#2').length == 1
-    assert resp.pyquery('div#inspect-drafts tr#2 td.label').text() == '2nd page'
-    assert resp.pyquery('div#inspect-drafts tr#2 td.percent').text() == '20.0%'
-    assert resp.pyquery('div#inspect-drafts tr#2 td.total').text() == '(1/5)'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="0"]').length == 1
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="0"] td.label').text() == '1st page'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="0"] td.percent').text() == '20.0%'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="0"] td.total').text() == '(1/5)'
 
-    assert resp.pyquery('div#inspect-drafts tr#4').length == 1
-    assert resp.pyquery('div#inspect-drafts tr#4 td.label').text() == '3rd page'
-    assert resp.pyquery('div#inspect-drafts tr#4 td.percent').text() == '20.0%'
-    assert resp.pyquery('div#inspect-drafts tr#4 td.total').text() == '(1/5)'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="2"]').length == 1
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="2"] td.label').text() == '2nd page'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="2"] td.percent').text() == '20.0%'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="2"] td.total').text() == '(1/5)'
 
-    assert resp.pyquery('div#inspect-drafts tr#_confirmation_page').length == 1
-    assert resp.pyquery('div#inspect-drafts tr#_confirmation_page td.label').text() == 'Confirmation page'
-    assert resp.pyquery('div#inspect-drafts tr#_confirmation_page td.percent').text() == '20.0%'
-    assert resp.pyquery('div#inspect-drafts tr#_confirmation_page td.total').text() == '(1/5)'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="4"]').length == 1
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="4"] td.label').text() == '3rd page'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="4"] td.percent').text() == '20.0%'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="4"] td.total').text() == '(1/5)'
 
-    assert resp.pyquery('div#inspect-drafts tr#_unknown').length == 1
-    assert resp.pyquery('div#inspect-drafts tr#_unknown td.label').text() == 'Unknown'
-    assert resp.pyquery('div#inspect-drafts tr#_unknown td.percent').text() == '20.0%'
-    assert resp.pyquery('div#inspect-drafts tr#_unknown td.total').text() == '(1/5)'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="_confirmation_page"]').length == 1
+    assert (
+        resp.pyquery('div#inspect-drafts tr[data-page-id="_confirmation_page"] td.label').text()
+        == 'Confirmation page'
+    )
+    assert (
+        resp.pyquery('div#inspect-drafts tr[data-page-id="_confirmation_page"] td.percent').text() == '20.0%'
+    )
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="_confirmation_page"] td.total').text() == '(1/5)'
+
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="_unknown"]').length == 1
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="_unknown"] td.label').text() == 'Unknown'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="_unknown"] td.percent').text() == '20.0%'
+    assert resp.pyquery('div#inspect-drafts tr[data-page-id="_unknown"] td.total').text() == '(1/5)'
 
 
 def test_form_import_fields(pub):

wcs/templates/wcs/backoffice/formdef-inspect.html

@@ -95,14 +95,14 @@
         {% if drafts %}
           <div class="infonotice">
             <p>{% trans "Statistics on drafts by page." %}</p>
-            <p>{% trans "Lifespan of drafts (in days)" %}{% trans ":" %} {{ formdef.drafts_lifespan|default_if_none:_('default value') }}.</p>
+            <p>{% trans "Lifespan of drafts (in days)" %}{% trans ":" %} {{ formdef.get_drafts_lifespan }}.</p>
           </div>
           <table class="stats">
             <tbody>
               {% for page_drafts in drafts %}
                 {% with page_id=page_drafts.0 draft_data=page_drafts.1 %}
                   {% if draft_data.total %}
-                    <tr id="{{ page_id }}">
+                    <tr data-page-id="{{ page_id }}">
                       <td class="label">
                         {% if page_id == "_unknown" %}
                           {% trans "Unknown" %}