misc: pylint fix unused-import (#52222)

wcs/admin/data_sources.py

@@ -30,7 +30,6 @@ from wcs.data_sources import NamedDataSource
 from wcs.data_sources import RefreshAgendas
 from wcs.data_sources import get_structured_items
 from wcs.data_sources import has_chrono
-from wcs.formdef import FormDef
 from wcs.formdef import get_formdefs_of_all_kinds
 from wcs.qommon import _
 from wcs.qommon import errors
@@ -45,7 +44,6 @@ from wcs.qommon.form import Form
 from wcs.qommon.form import HtmlWidget
 from wcs.qommon.form import StringWidget
 from wcs.qommon.form import TextWidget
-from wcs.qommon.form import UrlWidget
 from wcs.qommon.form import get_response
 from wcs.qommon.form import get_session
 

wcs/admin/settings.py

@@ -73,7 +73,6 @@ from wcs.qommon.form import StringWidget
 from wcs.qommon.form import TextWidget
 from wcs.qommon.form import UrlWidget
 from wcs.qommon.form import WidgetList
-from wcs.qommon.sms import SMS
 from wcs.workflows import Workflow
 from wcs.workflows import WorkflowImportError
 

wcs/backoffice/data_management.py

@@ -18,13 +18,10 @@ import csv
 import datetime
 import io
 
-from django.utils.encoding import force_text
 from quixote import get_publisher
 from quixote import get_request
 from quixote import get_response
 from quixote import redirect
-from quixote.html import TemplateIO
-from quixote.html import htmlescape
 from quixote.html import htmltext
 
 from wcs import fields

wcs/backoffice/management.py

@@ -25,7 +25,6 @@ import urllib.parse
 import zipfile
 
 import vobject
-from django.conf import settings
 from django.utils.encoding import force_text
 from quixote import get_publisher
 from quixote import get_request

wcs/backoffice/root.py

@@ -41,11 +41,11 @@ from ..qommon import template
 from ..qommon.afterjobs import AfterJob
 from ..qommon.backoffice import BackofficeRootDirectory
 from ..qommon.backoffice.menu import html_top
-from . import cards
-from . import data_management
-from . import management
-from . import studio
-from . import submission
+from .cards import CardsDirectory
+from .data_management import DataManagementDirectory
+from .management import ManagementDirectory
+from .studio import StudioDirectory
+from .submission import SubmissionDirectory
 
 
 class RootDirectory(BackofficeRootDirectory):
@@ -56,11 +56,11 @@ class RootDirectory(BackofficeRootDirectory):
     settings = wcs.admin.settings.SettingsDirectory()
     users = wcs.admin.users.UsersDirectory()
     workflows = wcs.admin.workflows.WorkflowsDirectory()
-    management = management.ManagementDirectory()
-    studio = studio.StudioDirectory()
-    cards = cards.CardsDirectory()
-    data = data_management.DataManagementDirectory()
-    submission = submission.SubmissionDirectory()
+    management = ManagementDirectory()
+    studio = StudioDirectory()
+    cards = CardsDirectory()
+    data = DataManagementDirectory()
+    submission = SubmissionDirectory()
 
     menu_items = [
         ('submission/', N_('Submission')),

wcs/carddef.py

@@ -27,7 +27,6 @@ from wcs.formdef import get_formdefs_of_all_kinds
 from .qommon import N_
 from .qommon import _
 from .qommon import misc
-from .qommon.storage import Contains
 from .qommon.storage import Equal
 from .qommon.storage import ILike
 from .qommon.storage import NotEqual

wcs/context_processors.py

@@ -30,7 +30,6 @@ def publisher(request):
     template_base = 'wcs/base.html'
     if request.path.startswith('/backoffice/'):
         template_base = 'wcs/blank.html'
-    from .variables import LazyRequest
 
     return {
         'publisher': get_publisher,

wcs/ctl/check_hobos.py

@@ -26,7 +26,6 @@ import tempfile
 import urllib.parse
 
 from django.utils.encoding import force_bytes
-from django.utils.encoding import force_text
 from quixote import cleanup
 
 from wcs.admin.settings import UserFieldsFormDef

wcs/ctl/management/commands/runjob.py

@@ -14,10 +14,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
-import sys
-
 from django.core.management import CommandError
-from quixote import get_publisher
 
 from wcs.qommon.http_response import AfterJob
 

wcs/formdata.py

@@ -27,7 +27,6 @@ from quixote import get_request
 from quixote import get_session
 from quixote.http_request import Upload
 
-from .fields import FileField
 from .qommon import N_
 from .qommon import _
 from .qommon import misc

wcs/formdef.py

@@ -1703,8 +1703,6 @@ def clean_drafts(publisher):
 
 
 def clean_unused_files(publisher):
-    from wcs.wf.attachment import AttachmentEvolutionPart
-
     unused_files_behaviour = publisher.get_site_option('unused-files-behaviour')
     if unused_files_behaviour not in ('move', 'remove'):
         return

wcs/forms/common.py

@@ -35,8 +35,6 @@ from wcs.api_utils import is_url_signed
 from wcs.api_utils import sign_url_auto_orig
 from wcs.blocks import BlockSubWidget
 from wcs.blocks import BlockWidget
-from wcs.fields import FileField
-from wcs.fields import WidgetField
 from wcs.qommon.admin.texts import TextsDirectory
 from wcs.workflows import EditableWorkflowStatusItem
 

wcs/portfolio.py

@@ -15,7 +15,6 @@
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
 import base64
-import hashlib
 import json
 import urllib.parse
 
@@ -34,7 +33,6 @@ from wcs.api_utils import sign_url
 
 from .qommon import N_
 from .qommon import get_logger
-from .qommon.misc import http_get_page
 from .qommon.misc import http_post_request
 from .qommon.misc import json_loads
 from .qommon.misc import urlopen

wcs/publisher.py

@@ -14,11 +14,9 @@
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
-import decimal
 import json
 import os
 import pickle
-import random
 import re
 import socket
 import sys
@@ -27,7 +25,6 @@ import zipfile
 from contextlib import contextmanager
 
 from django.utils.encoding import force_text
-from django.utils.formats import localize
 
 from .Defaults import *
 
@@ -36,7 +33,6 @@ try:
 except ImportError:
     pass
 
-import pickle
 
 from wcs.qommon import force_str
 

wcs/qommon/admin/emails.py

@@ -23,7 +23,6 @@ from quixote.html import htmltext
 
 from .. import _
 from .. import get_cfg
-from .. import misc
 from ..admin.cfg import cfg_submit
 from ..backoffice.menu import html_top
 from ..form import CheckboxWidget

wcs/qommon/admin/texts.py

@@ -26,7 +26,6 @@ from quixote.html import htmltext
 from wcs.qommon import _
 from wcs.qommon import ezt
 from wcs.qommon import get_cfg
-from wcs.qommon import misc
 from wcs.qommon.backoffice.menu import html_top
 from wcs.qommon.form import Form
 from wcs.qommon.form import WysiwygTextWidget

wcs/qommon/backoffice/menu.py

@@ -15,11 +15,7 @@
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
 from quixote import get_publisher
-from quixote import get_request
 from quixote import get_response
-from quixote import get_session
-from quixote.html import TemplateIO
-from quixote.html import htmltext
 
 from .. import _
 from .. import get_cfg

wcs/qommon/form.py

@@ -27,7 +27,6 @@ import mimetypes
 import os
 import random
 import re
-import socket
 import sys
 import tempfile
 import time
@@ -37,8 +36,6 @@ try:
 except ImportError:
     Image = None
 
-from .storage import atomic_write
-
 try:
     from feedparser import _sanitizeHTML
 except ImportError:
@@ -79,8 +76,6 @@ from quixote.html import htmlescape
 from quixote.html import htmltag
 from quixote.html import htmltext
 from quixote.html import stringify
-from quixote.http_request import Upload
-from quixote.util import randbytes
 
 from wcs.conditions import Condition
 from wcs.conditions import ValidationError
@@ -94,7 +89,6 @@ from . import ngettext
 from .humantime import humanduration2seconds
 from .humantime import seconds2humanduration
 from .humantime import timewords
-from .misc import C_
 from .misc import HAS_PDFTOPPM
 from .misc import json_loads
 from .misc import strftime
@@ -103,7 +97,6 @@ from .template import Template
 from .template import TemplateError
 from .template import render as render_template
 from .template_utils import render_block_to_string
-from .upload_storage import PicklableUpload
 from .upload_storage import UploadStorageError
 
 QuixoteForm = Form

wcs/qommon/http_response.py

@@ -15,16 +15,12 @@
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
 import hashlib
-import sys
-import time
-import traceback
 
 import quixote.http_response
 from django.utils.encoding import force_bytes
 from quixote import get_publisher
 from quixote import get_request
 
-from . import N_
 from .afterjobs import AfterJob
 
 

wcs/qommon/ident/password.py

@@ -14,7 +14,6 @@
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
-import csv
 import random
 import time
 
@@ -23,7 +22,6 @@ from quixote import get_request
 from quixote import get_response
 from quixote import get_session
 from quixote import redirect
-from quixote.directory import AccessControlled
 from quixote.directory import Directory
 from quixote.html import TemplateIO
 from quixote.html import htmltext
@@ -42,8 +40,6 @@ from .. import storage as st
 from .. import template
 from .. import tokens
 from ..admin.emails import EmailsDirectory
-from ..admin.menu import command_icon
-from ..afterjobs import AfterJob
 from ..backoffice.menu import html_top
 from ..cron import CronJob
 from ..form import CheckboxWidget

wcs/qommon/ident/password_accounts.py

@@ -19,7 +19,6 @@ import hashlib
 from django.contrib.auth.hashers import check_password
 from django.contrib.auth.hashers import make_password
 from django.utils.encoding import force_bytes
-from django.utils.encoding import force_text
 from quixote import get_publisher
 
 from wcs.qommon import force_str

wcs/qommon/publisher.py

@@ -21,7 +21,6 @@ import codecs
 import collections
 import configparser
 import datetime
-import fcntl
 import hashlib
 import importlib
 import inspect
@@ -40,7 +39,6 @@ import sys
 import time
 import traceback
 import urllib.parse
-import xml.etree.ElementTree as ET
 from decimal import Decimal
 
 from django.conf import settings
@@ -52,7 +50,6 @@ from quixote.publish import Publisher
 from quixote.publish import get_publisher
 from quixote.publish import get_request
 from quixote.publish import get_response
-from quixote.publish import redirect
 
 from . import N_
 from . import _

wcs/qommon/sms.py

@@ -14,18 +14,10 @@
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
-import re
-import urllib.parse
-
 from wcs.wscalls import call_webservice
 
-from . import N_
-from . import errors
 from . import get_cfg
 from . import get_logger
-from . import misc
-from .form import PasswordWidget
-from .form import StringWidget
 
 
 class PasserelleSMS(object):

wcs/qommon/template.py

@@ -27,8 +27,6 @@ from django.template import engines
 from django.template.loader import render_to_string
 from django.utils.encoding import force_text
 from django.utils.encoding import smart_text
-from django.utils.safestring import SafeString
-from django.utils.safestring import SafeText
 from quixote import get_publisher
 from quixote import get_request
 from quixote import get_response

wcs/qommon/xml_storage.py

@@ -20,7 +20,6 @@ import xml.etree.ElementTree as ET
 from django.utils.encoding import force_text
 from quixote import get_publisher
 
-from . import force_str
 from .misc import indent_xml
 from .misc import xml_node_text
 from .storage import StorableObject

wcs/root.py

@@ -44,12 +44,12 @@ from .qommon import errors
 from .qommon import get_cfg
 from .qommon import get_logger
 from .qommon import ident
-from .qommon import pages
 from .qommon import saml2
 from .qommon import template
 from .qommon.afterjobs import AfterJobStatusDirectory
 from .qommon.form import Form
 from .qommon.form import RadiobuttonsWidget
+from .qommon.pages import PagesDirectory
 from .qommon.upload_storage import UploadStorageError
 
 
@@ -280,7 +280,7 @@ class RootDirectory(Directory):
     api = ApiDirectory()
     themes = template.ThemesDirectory()
     myspace = MyspaceDirectory()
-    pages = pages.PagesDirectory()
+    pages = PagesDirectory()
     fargo = portfolio.FargoDirectory()
     static = StaticsDirectory()
     actions = ActionsDirectory()

wcs/wf/attachment.py

@@ -31,7 +31,6 @@ from wcs.workflows import register_item_class
 
 from ..qommon import N_
 from ..qommon import _
-from ..qommon import get_cfg
 from ..qommon.errors import TraversalError
 from ..qommon.form import CheckboxWidget
 from ..qommon.form import FileSizeWidget

wcs/wf/export_to_model.py

@@ -57,7 +57,6 @@ from ..qommon import get_logger
 from ..qommon import misc
 from ..qommon.form import CheckboxWidget
 from ..qommon.form import ComputedExpressionWidget
-from ..qommon.form import PicklableUpload
 from ..qommon.form import RadiobuttonsWidget
 from ..qommon.form import SingleSelectWidget
 from ..qommon.form import StringWidget

wcs/wf/geolocate.py

@@ -20,8 +20,6 @@ import urllib.parse
 
 try:
     from PIL import Image
-    from PIL.ExifTags import GPSTAGS
-    from PIL.ExifTags import TAGS
     from PIL.TiffImagePlugin import IFDRational
 except ImportError:
     Image = None

wcs/wf/notification.py

@@ -24,7 +24,6 @@ from wcs.workflows import template_on_formdata
 
 from ..qommon import N_
 from ..qommon import _
-from ..qommon import ezt
 from ..qommon import get_logger
 from ..qommon.form import ComputedExpressionWidget
 from ..qommon.form import SingleSelectWidget

wcs/workflows.py

@@ -29,7 +29,6 @@ from django.utils.encoding import force_text
 from quixote import get_publisher
 from quixote import get_request
 from quixote import get_response
-from quixote import redirect
 from quixote.html import TemplateIO
 from quixote.html import htmltext
 
@@ -65,7 +64,6 @@ from .qommon.humantime import seconds2humanduration
 from .qommon.misc import C_
 from .qommon.misc import file_digest
 from .qommon.misc import get_as_datetime
-from .qommon.misc import get_foreground_colour
 from .qommon.misc import xml_node_text
 from .qommon.storage import Contains
 from .qommon.storage import NotEqual
@@ -3331,26 +3329,26 @@ register_item_class(EditableWorkflowStatusItem)
 
 
 def load_extra():
-    from .wf import aggregation_email
-    from .wf import anonymise
-    from .wf import attachment
-    from .wf import backoffice_fields
-    from .wf import create_carddata
-    from .wf import create_formdata
-    from .wf import criticality
-    from .wf import dispatch
-    from .wf import edit_carddata
-    from .wf import export_to_model
-    from .wf import external_workflow
-    from .wf import form
-    from .wf import geolocate
-    from .wf import jump
-    from .wf import notification
-    from .wf import profile
-    from .wf import redirect_to_url
-    from .wf import register_comment
-    from .wf import remove
-    from .wf import resubmit
-    from .wf import roles
-    from .wf import timeout_jump
-    from .wf import wscall
+    from .wf import aggregation_email  # noqa pylint: disable=W0611
+    from .wf import anonymise  # noqa pylint: disable=W0611
+    from .wf import attachment  # noqa pylint: disable=W0611
+    from .wf import backoffice_fields  # noqa pylint: disable=W0611
+    from .wf import create_carddata  # noqa pylint: disable=W0611
+    from .wf import create_formdata  # noqa pylint: disable=W0611
+    from .wf import criticality  # noqa pylint: disable=W0611
+    from .wf import dispatch  # noqa pylint: disable=W0611
+    from .wf import edit_carddata  # noqa pylint: disable=W0611
+    from .wf import export_to_model  # noqa pylint: disable=W0611
+    from .wf import external_workflow  # noqa pylint: disable=W0611
+    from .wf import form  # noqa pylint: disable=W0611
+    from .wf import geolocate  # noqa pylint: disable=W0611
+    from .wf import jump  # noqa pylint: disable=W0611
+    from .wf import notification  # noqa pylint: disable=W0611
+    from .wf import profile  # noqa pylint: disable=W0611
+    from .wf import redirect_to_url  # noqa pylint: disable=W0611
+    from .wf import register_comment  # noqa pylint: disable=W0611
+    from .wf import remove  # noqa pylint: disable=W0611
+    from .wf import resubmit  # noqa pylint: disable=W0611
+    from .wf import roles  # noqa pylint: disable=W0611
+    from .wf import timeout_jump  # noqa pylint: disable=W0611
+    from .wf import wscall  # noqa pylint: disable=W0611