provide clearer erroneous template filter use message (#86062)
gitea/wcs/pipeline/head This commit looks good Details

This commit is contained in:
Paul Marillonnet 2024-01-24 09:29:03 +01:00
parent 02968c0c79
commit fd6a336f5e
2 changed files with 3 additions and 3 deletions

View File

@ -1940,14 +1940,14 @@ def test_lazy_formdata_queryset_filter(pub, variable_test_data):
assert tmpl.render(context) == 'None'
assert pub.loggederror_class.count() == 1
logged_error = pub.loggederror_class.select()[0]
assert logged_error.summary == '|pending used on invalid queryset (\'\')'
assert logged_error.summary == '|pending used on inadequate object (\'\')'
pub.loggederror_class.wipe()
tmpl = Template('{{""|filter_value:"foo"}}')
assert tmpl.render(context) == 'None'
assert pub.loggederror_class.count() == 1
logged_error = pub.loggederror_class.select()[0]
assert logged_error.summary == '|filter_value used on invalid queryset (\'\')'
assert logged_error.summary == '|filter_value used on inadequate object (\'\')'
def test_lazy_formdata_queryset_filter_non_unique_varname(pub, variable_test_data):

View File

@ -744,7 +744,7 @@ def decorate_queryset_filter(func, name, attr):
@functools.wraps(func)
def f(queryset, *args, **kwargs):
if not hasattr(queryset, attr):
get_publisher().record_error(_('|%s used on invalid queryset (%r)') % (name, queryset))
get_publisher().record_error(_('|%s used on inadequate object (%r)') % (name, queryset))
return None
return func(queryset, *args, **kwargs)