admin: do not show role selection in new form dialog (#6336)

tests/test_admin_pages.py

@@ -85,7 +85,6 @@ def test_forms_new():
     assert 'New Form' in resp.body
     resp = resp.click('New Form')
     resp.forms[0]['name'] = 'form title'
-    resp.forms[0]['roles$element0'].value = 'foobar'
     resp = resp.forms[0].submit()
     assert resp.location == 'http://example.net/admin/forms/1/'
     resp = resp.follow()
@@ -95,7 +94,6 @@ def test_forms_new():
     formdef = FormDef.get(1)
     assert formdef.name == 'form title'
     assert formdef.url_name == 'form-title'
-    assert formdef.roles == [1]
     assert formdef.fields == []
     assert formdef.disabled == True
     assert formdef.last_modification_user_id == 'admin'

wcs/admin/forms.py

@@ -75,13 +75,6 @@ class FormDefUI(object):
             form.add(SingleSelectWidget, 'workflow_id', title = _('Workflow'),
                     value = formdef.workflow_id,
                     options = [(None, _('Default Workflow'), '')] + workflows)
-        form.add(WidgetList, 'roles', title = _('User Roles'), element_type = SingleSelectWidget,
-                hint = _('Only show this form to the given roles.'),
-                value = formdef.roles,
-                add_element_label = _('Add Role'),
-                element_kwargs = {'render_br': False,
-                'options': [('', '---'),
-                            (logged_users_role().id, logged_users_role().name)] + get_user_roles()})
         form.add_submit('submit', _('Submit'))
         form.add_submit('cancel', _('Cancel'))
         return form
@@ -107,12 +100,6 @@ class FormDefUI(object):
             if widget:
                 setattr(formdef, f, widget.parse())
 
-        roles = form.get_widget('roles').parse()
-        if roles:
-            formdef.roles = [x for x in roles if x]
-        else:
-            formdef.roles = []
-
         if not formdef.fields:
             formdef.fields = []