misc: pylint fix dangerous-default-value (#52222)

wcs/admin/settings.py

@@ -297,7 +297,8 @@ class UsersDirectory(Directory):
 class FileTypesDirectory(Directory):
     _q_exports = ['', 'add']
 
-    def get_form(self, filetype={}):
+    def get_form(self, filetype=None):
+        filetype = filetype or {}
         form = Form(enctype='multipart/form-data')
         form.add(StringWidget, 'label', title=_('Label'), required=True, value=filetype.get('label'))
         form.add(

wcs/conditions.py

@@ -34,12 +34,12 @@ class Condition(object):
     record_errors = True
     log_errors = False
 
-    def __init__(self, condition, context={}):
+    def __init__(self, condition, context=None):
         if not condition:
             condition = {}
         self.type = condition.get('type')
         self.value = condition.get('value')
-        self.context = context
+        self.context = context or {}
 
     def __repr__(self):
         return '<%s (%s) %r>' % (self.__class__.__name__, self.type, self.value)

wcs/formdef.py

@@ -671,7 +671,8 @@ class FormDef(StorableObject):
     def get_page(self, page_no):
         return [x for x in self.fields if x.type == 'page'][page_no]
 
-    def create_view_form(self, dict={}, use_tokens=True, visible=True):
+    def create_view_form(self, dict=None, use_tokens=True, visible=True):
+        dict = dict or {}
         form = Form(enctype='multipart/form-data', use_tokens=use_tokens)
         if not visible:
             form.attrs['style'] = 'display: none;'

wcs/forms/root.py

@@ -1764,7 +1764,10 @@ class RootDirectory(AccessControlled, Directory):
                 r += htmltext('</ul>')
         return r.getvalue()
 
-    def form_list(self, list, category=None, title=None, session=None, user_forms=None, advertised_forms=[]):
+    def form_list(
+        self, list, category=None, title=None, session=None, user_forms=None, advertised_forms=None
+    ):
+        advertised_forms = advertised_forms or []
         r = TemplateIO(html=True)
 
         keywords = {}

wcs/qommon/__init__.py

@@ -85,12 +85,12 @@ class _Timer(TenantAwareThread):
 
     """
 
-    def __init__(self, interval, function, args=[], kwargs={}):
+    def __init__(self, interval, function, args=None, kwargs=None):
         super().__init__()
         self.interval = interval
         self.function = function
-        self.args = args
-        self.kwargs = kwargs
+        self.args = args or []
+        self.kwargs = kwargs or {}
         self.finished = threading.Event()
 
     def cancel(self):

wcs/qommon/ctl.py

@@ -38,7 +38,8 @@ class Command(object):
     name = None
     usage_args = '[ options ... ]'
 
-    def __init__(self, options=[]):
+    def __init__(self, options=None):
+        options = options or []
         self.config = configparser.ConfigParser()
         self.options = options + [
             make_option('--extra', metavar='DIR', action='append', dest='extra', default=[]),
@@ -88,8 +89,8 @@ class Command(object):
 
 
 class Ctl(object):
-    def __init__(self, cmd_prefixes=[]):
-        self.cmd_prefixes = cmd_prefixes
+    def __init__(self, cmd_prefixes=None):
+        self.cmd_prefixes = cmd_prefixes or []
         self.parser = optparse.OptionParser(
             usage='%prog [ -f config ] command [ options ... ]', add_help_option=False
         )

wcs/qommon/form.py

@@ -1723,7 +1723,7 @@ class WidgetList(quixote.form.widget.WidgetList):
         name,
         value=None,
         element_type=StringWidget,
-        element_kwargs={},
+        element_kwargs=None,
         add_element_label="Add row",
         max_items=None,
         **kwargs,
@@ -1734,7 +1734,7 @@ class WidgetList(quixote.form.widget.WidgetList):
 
         CompositeWidget.__init__(self, name, value=value, **kwargs)
         self.element_type = element_type
-        self.element_kwargs = element_kwargs
+        self.element_kwargs = element_kwargs or {}
         self.element_names = []
         self.max_items = max_items
 
@@ -1836,8 +1836,8 @@ class WidgetDict(quixote.form.widget.WidgetDict):
         hint='',
         element_key_type=StringWidget,
         element_value_type=StringWidget,
-        element_key_kwargs={},
-        element_value_kwargs={},
+        element_key_kwargs=None,
+        element_value_kwargs=None,
         add_element_label='Add row',
         **kwargs,
     ):
@@ -1851,8 +1851,8 @@ class WidgetDict(quixote.form.widget.WidgetDict):
             value,
             element_key_type=element_key_type,
             element_value_type=element_value_type,
-            element_key_kwargs=element_key_kwargs,
-            element_value_kwargs=element_value_kwargs,
+            element_key_kwargs=element_key_kwargs or {},
+            element_value_kwargs=element_value_kwargs or {},
             add_element_label=add_element_label,
             **kwargs,
         )

wcs/qommon/ident/franceconnect.py

@@ -184,7 +184,8 @@ class MethodAdminDirectory(Directory):
     ]
 
     @classmethod
-    def get_form(cls, instance={}):
+    def get_form(cls, instance=None):
+        instance = instance or {}
         form = Form(enctype='multipart/form-data')
         for key, title in cls.CONFIG:
             attrs = {}

wcs/qommon/ident/idp.py

@@ -290,7 +290,8 @@ class AdminIDPDir(Directory):
         return options
 
     @classmethod
-    def get_form(cls, instance={}):
+    def get_form(cls, instance=None):
+        instance = instance or {}
         form = Form(enctype='multipart/form-data')
         form.add(FileWidget, 'metadata', title=_('Metadata'), required=not instance)
         form.add(FileWidget, 'publickey', title=_('Public Key'), required=False)

wcs/qommon/misc.py

@@ -346,8 +346,9 @@ def format_time(datetime, formatstring, gmtime=False):
 
 
 def _http_request(
-    url, method='GET', body=None, headers={}, cert_file=None, timeout=None, raise_on_http_errors=False
+    url, method='GET', body=None, headers=None, cert_file=None, timeout=None, raise_on_http_errors=False
 ):
+    headers = headers or {}
     get_publisher().reload_cfg()
 
     splitted_url = urllib.parse.urlsplit(url)

wcs/qommon/saml2utils.py

@@ -172,8 +172,9 @@ class Metadata(object):
         return idp_head + idp_key['signing'] + idp_key['encryption'] + idp_body
 
     def get_saml2_metadata(
-        self, signing_pem_key='', encryption_pem_key='', do_idp=False, do_sp=False, endpoints={}
+        self, signing_pem_key='', encryption_pem_key='', do_idp=False, do_sp=False, endpoints=None
     ):
+        endpoints = endpoints or {}
         prologue = (
             '''<?xml version="1.0"?>
 <EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata"

wcs/qommon/storage.py

@@ -538,7 +538,8 @@ class StorableObject(object):
         return o
 
     @classmethod
-    def rebuild_indexes(cls, indexes=[]):
+    def rebuild_indexes(cls, indexes=None):
+        indexes = indexes or []
         if not (cls._indexes or cls._hashed_indexes):
             return
 

wcs/qommon/template.py

@@ -509,10 +509,11 @@ class Template(object):
         else:
             self.render = self.null_render
 
-    def null_render(self, context={}):
+    def null_render(self, context=None):
         return str(self.value)
 
-    def django_render(self, context={}):
+    def django_render(self, context=None):
+        context = context or {}
         try:
             rendered = self.template.render(context)
         except (DjangoTemplateSyntaxError, DjangoVariableDoesNotExist) as e:
@@ -527,7 +528,8 @@ class Template(object):
             return rendered
         return re.sub(r'[\uE000-\uF8FF]', '', rendered)
 
-    def ezt_render(self, context={}):
+    def ezt_render(self, context=None):
+        context = context or {}
         fd = io.StringIO()
         try:
             self.template.generate(fd, context)

wcs/qommon/tokens.py

@@ -27,7 +27,8 @@ class Token(StorableObject):
     type = None
     expiration = None
 
-    def __init__(self, expiration_delay=86400, size=16, chars=list(string.digits + string.ascii_letters)):
+    def __init__(self, expiration_delay=86400, size=16, chars=None):
+        chars = chars or list(string.digits + string.ascii_letters)
         StorableObject.__init__(self, self.get_new_id(size, chars))
         if expiration_delay:
             self.expiration = time.time() + expiration_delay

wcs/wf/dispatch.py

@@ -68,7 +68,8 @@ class AutomaticDispatchTableWidget(WidgetListAsTable):
 class RuleNode(XmlSerialisable):
     node_name = 'rule'
 
-    def __init__(self, rule={}):
+    def __init__(self, rule=None):
+        rule = rule or {}
         self.role_id = rule.get('role_id')
         self.value = rule.get('value')
 

wcs/wf/profile.py

@@ -101,7 +101,8 @@ class ProfileUpdateTableWidget(WidgetListAsTable):
 class FieldNode(XmlSerialisable):
     node_name = 'field'
 
-    def __init__(self, rule={}):
+    def __init__(self, rule=None):
+        rule = rule or {}
         self.field_id = rule.get('field_id') or ''
         self.value = rule.get('value') or ''