admin: update testdef store call with comments (#88755)

tests/admin_pages/test_tests.py

@@ -98,6 +98,9 @@ def test_tests_page(pub):
     resp = resp.click('Second test')
     assert 'This test is empty' in resp.text
 
+    resp = resp.click('History')
+    assert 'Creation (empty)' in resp.text
+
     # test run with empty test is allowed
     app.get('/backoffice/forms/1/tests/results/run').follow()
 

wcs/admin/tests.py

@@ -134,12 +134,12 @@ class TestEditPage(FormBackofficeEditPage):
         self.testdef.data = testdef.data
 
         self.testdef.expected_error = get_request().form.get('error')
-        self.testdef.store()
+        self.testdef.store(comment=_('Mark test as failing'))
         return redirect('..')
 
     def change_submission_mode(self):
         self.testdef.is_in_backoffice = not self.testdef.is_in_backoffice
-        self.testdef.store()
+        self.testdef.store(comment=_('Change submission mode'))
         return redirect('.')
 
 
@@ -284,7 +284,7 @@ class TestPage(FormBackOfficeStatusPage):
             else:
                 self.testdef.data['user'] = None
 
-            self.testdef.store()
+            self.testdef.store(comment=_('Change in options'))
             return redirect('.')
 
     def duplicate(self):
@@ -315,7 +315,7 @@ class TestPage(FormBackOfficeStatusPage):
 
         self.testdef.name = form.get_widget('name').parse()
         self.testdef = TestDef.import_from_xml_tree(self.testdef.export_to_xml(), self.formdef)
-        self.testdef.store()
+        self.testdef.store(comment=_('Creation (from duplication)'))
 
         return redirect(self.testdef.get_admin_url())
 
@@ -416,7 +416,7 @@ class TestsDirectory(Directory):
             testdef = TestDef.create_from_formdata(self.objectdef, self.objectdef.data_class()())
             testdef.name = form.get_widget('name').parse()
             testdef.agent_id = str(get_session().user)
-            testdef.store()
+            testdef.store(comment=_('Creation (empty)'))
             return redirect(testdef.get_admin_url() + 'edit-data/')
         else:
             formdata_id = form.get_widget('formdata').parse()
@@ -429,7 +429,7 @@ class TestsDirectory(Directory):
             )
             testdef.name = form.get_widget('name').parse()
             testdef.agent_id = str(get_session().user)
-            testdef.store()
+            testdef.store(comment=_('Creation (from formdata)'))
             return redirect(testdef.get_admin_url())
 
     def p_import(self):
@@ -467,7 +467,7 @@ class TestsDirectory(Directory):
             form.set_error('file', _('Invalid File'))
             raise e
 
-        testdef.store()
+        testdef.store(comment=_('Creation (from import)'))
         get_session().message = ('info', _('Test "%s" has been successfully imported.') % testdef.name)
         return redirect('.')
 
@@ -875,6 +875,7 @@ class WebserviceResponsePage(Directory):
         self.webservice_response.method = form.get_widget('method').parse()
         self.webservice_response.post_data = form.get_widget('post_data').parse()
         self.webservice_response.store()
+        self.testdef.store(comment=_('Change webservice response "%s"') % self.webservice_response.name)
 
         return redirect('..')
 
@@ -900,6 +901,9 @@ class WebserviceResponsePage(Directory):
         new_webservice_response.id = None
         new_webservice_response.name = '%s %s' % (new_webservice_response.name, _('(copy)'))
         new_webservice_response.store()
+        self.testdef.store(
+            comment=_('Duplication of webservice response "%s"') % self.webservice_response.name
+        )
         return redirect('..')
 
 
@@ -952,5 +956,6 @@ class WebserviceResponseDirectory(Directory):
         webservice_response.testdef_id = self.testdef.id
         webservice_response.name = form.get_widget('name').parse()
         webservice_response.store()
+        self.testdef.store(comment=_('New webservice response "%s"') % webservice_response.name)
 
         return redirect(self.testdef.get_admin_url() + 'webservice-responses/%s/' % webservice_response.id)

wcs/admin/workflow_tests.py

@@ -69,7 +69,7 @@ class WorkflowTestActionPage(Directory):
 
             setattr(self.action, widget.name, value)
 
-        self.testdef.store()
+        self.testdef.store(comment=_('Change in workflow test action "%s"') % self.action.label)
         return redirect('..')
 
     def delete(self):
@@ -90,14 +90,14 @@ class WorkflowTestActionPage(Directory):
         self.testdef.workflow_tests.actions = [
             x for x in self.testdef.workflow_tests.actions if x.id != self.action.id
         ]
-        self.testdef.store()
+        self.testdef.store(comment=_('Deletion of workflow test action "%s"') % self.action.label)
         return redirect('..')
 
     def duplicate(self):
         new_action = copy.deepcopy(self.action)
         new_action.id = self.testdef.workflow_tests.get_new_action_id()
         self.testdef.workflow_tests.actions.append(new_action)
-        self.testdef.store()
+        self.testdef.store(comment=_('Duplication of workflow test action "%s"') % self.action.label)
         return redirect('..')
 
 
@@ -175,7 +175,7 @@ class WorkflowTestsDirectory(Directory):
             return r.getvalue()
 
         self.testdef.agent_id = form.get_widget('agent').parse()
-        self.testdef.store()
+        self.testdef.store(comment=_('Change in workflow test options'))
         return redirect('.')
 
     def new(self):
@@ -189,7 +189,7 @@ class WorkflowTestsDirectory(Directory):
         action_type = form.get_widget('type').parse()
         action_class = get_test_action_class_by_type(action_type)
         self.testdef.workflow_tests.add_action(action_class)
-        self.testdef.store()
+        self.testdef.store(comment=_('New test action "%s"') % action_class.label)
 
         return redirect('.')
 
@@ -218,7 +218,7 @@ class WorkflowTestsDirectory(Directory):
             return json.dumps({'success': 'ko'})
 
         self.testdef.workflow_tests.actions = new_actions
-        self.testdef.store()
+        self.testdef.store(comment=_('Change in workflow test actions order'))
 
         return json.dumps(
             {

wcs/forms/root.py

@@ -1969,7 +1969,7 @@ class FormPage(Directory, TempfileDirectoryMixin, FormTemplateMixin):
             testdef = TestDef.create_from_formdata(self.formdef, self.edited_data)
             self.testdef.data = testdef.data
             self.testdef.expected_error = None
-            self.testdef.store()
+            self.testdef.store(comment=_('Change in test data'))
             return redirect(self.formdef.get_admin_url() + 'tests/%s/' % self.testdef.id)
 
         evo = self.edited_data.evolution[-1]