misc: always create translation messages table (#86143)

tests/admin_pages/test_i18n.py

@@ -30,7 +30,7 @@ def pub():
     pub.cfg['language'] = {'language': 'en', 'multilinguism': True, 'languages': ['en', 'fr']}
     pub.write_cfg()
 
-    TranslatableMessage.do_table()
+    TranslatableMessage.do_table()  # update table with selected languages
 
     return pub
 

tests/backoffice_pages/test_i18n.py

@@ -27,7 +27,7 @@ def pub():
         'default_site_language': 'http',
     }
     pub.write_cfg()
-    TranslatableMessage.do_table()
+    TranslatableMessage.do_table()  # update table with selected languages
     return pub
 
 

tests/form_pages/test_i18n.py

@@ -37,7 +37,7 @@ def pub():
     with open(os.path.join(pub.app_dir, 'site-options.cfg'), 'w') as fd:
         pub.site_options.write(fd)
 
-    TranslatableMessage.do_table()
+    TranslatableMessage.do_table()  # update table with selected languages
 
     return pub
 

tests/test_i18n.py

@@ -39,7 +39,7 @@ def test_translation_columns(pub):
     assert not column_exists_in_table(cur, 'translatable_messages', 'string_fr')
     pub.cfg['language'] = {'language': 'en', 'multilinguism': True, 'languages': ['fr', 'de']}
     pub.write_cfg()
-    TranslatableMessage.do_table()
+    TranslatableMessage.do_table()  # update table with selected languages
     assert column_exists_in_table(cur, 'translatable_messages', 'string_de')
     assert column_exists_in_table(cur, 'translatable_messages', 'string_fr')
     # check it's not removed

tests/utilities.py

@@ -189,6 +189,7 @@ def create_temporary_pub(pickle_mode=False, lazy_mode=False):
         sql.Application.do_table()
         sql.ApplicationElement.do_table()
         sql.SearchableFormDef.do_table()
+        sql.TranslatableMessage.do_table()
         sql.init_global_table()
 
         conn.close()

wcs/publisher.py

@@ -439,6 +439,7 @@ class WcsPublisher(QommonPublisher):
             sql.Application.do_table()
             sql.ApplicationElement.do_table()
             sql.SearchableFormDef.do_table()
+            sql.TranslatableMessage.do_table()
             sql.do_meta_table()
             from .carddef import CardDef
             from .formdef import FormDef

wcs/sql.py

@@ -5032,7 +5032,7 @@ def get_period_total(
 # latest migration, number + description (description is not used
 # programmaticaly but will make sure git conflicts if two migrations are
 # separately added with the same number)
-SQL_LEVEL = (99, 'add more indexes')
+SQL_LEVEL = (100, 'always create translation messages table')
 
 
 def migrate_global_views(conn, cur):
@@ -5196,9 +5196,10 @@ def migrate():
         # 67: re-migrate legacy tokens
         do_tokens_table()
         migrate_legacy_tokens()
-    if sql_level < 79:
+    if sql_level < 100:
         # 68: multilinguism
         # 79: add translatable column to TranslatableMessage table
+        # 100: always create translation messages table
         TranslatableMessage.do_table()
     if sql_level < 87:
         # 72: add testdef table