misc: pylint on tests (#52630)

pylint.rc

@@ -6,7 +6,69 @@ cache-size=500
 init-hook="import sys, os; sys.path.append("wcs")'
 
 [MESSAGES CONTROL]
-disable=abstract-method,arguments-differ,assignment-from-no-return,assignment-from-none,attribute-defined-outside-init,broad-except,consider-using-dict-comprehension,consider-using-set-comprehension,consider-using-ternary,cyclic-import,deprecated-module,duplicate-code,duplicate-except,eval-used,exec-used,fixme,global-variable-undefined,import-outside-toplevel,inconsistent-return-statements,invalid-name,keyword-arg-before-vararg,len-as-condition,missing-class-docstring,missing-function-docstring,missing-module-docstring,no-else-return,no-member,no-self-use,non-parent-init-called,not-a-mapping,not-callable,possibly-unused-variable,protected-access,raise-missing-from,redefined-argument-from-local,redefined-builtin,redefined-outer-name,signature-differs,stop-iteration-return,subprocess-run-check,super-init-not-called,superfluous-parens,too-many-ancestors,too-many-arguments,too-many-boolean-expressions,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-nested-blocks,too-many-public-methods,too-many-return-statements,too-many-statements,undefined-loop-variable,unnecessary-comprehension,unnecessary-lambda,unsubscriptable-object,unsupported-membership-test,unused-argument
+disable=
+    abstract-method,
+    arguments-differ,
+    assignment-from-no-return,
+    assignment-from-none,
+    attribute-defined-outside-init,
+    broad-except,
+    consider-using-dict-comprehension,
+    consider-using-set-comprehension,
+    consider-using-ternary,
+    cyclic-import,
+    deprecated-module,
+    disallowed-name,
+    duplicate-code,
+    duplicate-except,
+    eval-used,
+    exec-used,
+    fixme,
+    global-variable-undefined,
+    import-outside-toplevel,
+    inconsistent-return-statements,
+    invalid-name,
+    keyword-arg-before-vararg,
+    len-as-condition,
+    missing-class-docstring,
+    missing-function-docstring,
+    missing-module-docstring,
+    no-else-return,
+    no-member,
+    no-self-use,
+    non-parent-init-called,
+    not-a-mapping,
+    not-callable,
+    pointless-statement,
+    possibly-unused-variable,
+    protected-access,
+    raise-missing-from,
+    redefined-argument-from-local,
+    redefined-builtin,
+    redefined-outer-name,
+    signature-differs,
+    stop-iteration-return,
+    subprocess-run-check,
+    super-init-not-called,
+    superfluous-parens,
+    too-many-ancestors,
+    too-many-arguments,
+    too-many-boolean-expressions,
+    too-many-branches,
+    too-many-function-args,
+    too-many-instance-attributes,
+    too-many-lines,
+    too-many-locals,
+    too-many-nested-blocks,
+    too-many-public-methods,
+    too-many-return-statements,
+    too-many-statements,
+    undefined-loop-variable,
+    unnecessary-comprehension,
+    unnecessary-lambda,
+    unsubscriptable-object,
+    unsupported-membership-test,
+    unused-argument
 
 
 [REPORTS]

tests/admin_pages/test_all.py

@@ -3,11 +3,12 @@
 import os
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/admin_pages/test_api_access.py

@@ -15,11 +15,11 @@
 # along with this program; if not, see <http://www.gnu.org/licenses/>.
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.api_access import ApiAccess
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_block.py

@@ -8,7 +8,6 @@ except ImportError:
     lasso = None
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -16,6 +15,7 @@ from wcs.blocks import BlockDef
 from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_role, create_superuser
 
 

tests/admin_pages/test_card.py

@@ -3,7 +3,6 @@
 import re
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.admin.settings import UserFieldsFormDef
@@ -14,6 +13,7 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.wf.form import FormWorkflowStatusItem, WorkflowFormFieldsFormDef
 from wcs.workflows import Workflow, WorkflowBackofficeFieldsFormDef, WorkflowVariablesFieldsFormDef
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_carddefcategory.py

@@ -1,12 +1,12 @@
 # -*- coding: utf-8 -*-
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.carddef import CardDef
 from wcs.categories import CardDefCategory
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_category.py

@@ -1,12 +1,12 @@
 # -*- coding: utf-8 -*-
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.categories import Category
 from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_datasource.py

@@ -13,7 +13,6 @@ except ImportError:
     lasso = None
 
 import pytest
-from utilities import HttpRequestsMocking, clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -24,6 +23,7 @@ from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 from wcs.workflows import Workflow, WorkflowBackofficeFieldsFormDef
 
+from ..utilities import HttpRequestsMocking, clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_form.py

@@ -10,7 +10,6 @@ import xml.etree.ElementTree as ET
 
 import mock
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -23,6 +22,7 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.workflows import Workflow
 from wcs.wscalls import NamedWsCall
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_role, create_superuser
 
 

tests/admin_pages/test_logged_errors.py

@@ -3,13 +3,13 @@
 import datetime
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.carddef import CardDef
 from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 from wcs.workflows import Workflow
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_role.py

@@ -1,11 +1,11 @@
 # -*- coding: utf-8 -*-
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_settings.py

@@ -14,7 +14,6 @@ except ImportError:
 import mock
 import pytest
 from quixote.http_request import Upload as QuixoteUpload
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -30,6 +29,7 @@ from wcs.wf.export_to_model import ExportToModel
 from wcs.workflows import CommentableWorkflowStatusItem, Workflow
 from wcs.wscalls import NamedWsCall
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_user.py

@@ -1,13 +1,13 @@
 # -*- coding: utf-8 -*-
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.admin.settings import UserFieldsFormDef
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_role, create_superuser
 
 

tests/admin_pages/test_workflow.py

@@ -13,7 +13,6 @@ except ImportError:
 
 import pytest
 from quixote.http_request import Upload as QuixoteUpload
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -45,6 +44,7 @@ from wcs.workflows import (
     item_classes,
 )
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/admin_pages/test_wscall.py

@@ -4,12 +4,12 @@ import io
 import xml.etree.ElementTree as ET
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs.qommon.http_request import HTTPRequest
 from wcs.wscalls import NamedWsCall
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/api/test_access.py

@@ -11,13 +11,14 @@ import urllib.parse
 import pytest
 from django.utils.encoding import force_bytes
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.api_utils import get_secret_and_orig, is_url_signed, sign_url
 from wcs.qommon.errors import AccessForbiddenError
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/api/test_all.py

@@ -7,13 +7,14 @@ import os
 import mock
 import pytest
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs.api_utils import sign_url
 from wcs.formdef import FormDef
 from wcs.qommon.afterjobs import AfterJob
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/api/test_carddef.py

@@ -11,7 +11,6 @@ import mock
 import pytest
 from django.utils.encoding import force_text
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs import fields, qommon
 from wcs.api_utils import sign_url
@@ -23,6 +22,7 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.upload_storage import PicklableUpload
 from wcs.workflows import Workflow, WorkflowBackofficeFieldsFormDef
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
 from .utils import sign_uri
 
 

tests/api/test_category.py

@@ -4,12 +4,12 @@ import os
 
 import pytest
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs.categories import Category
 from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
 from .utils import sign_uri
 
 

tests/api/test_custom_view.py

@@ -7,7 +7,6 @@ import zipfile
 
 import pytest
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs import fields
 from wcs.carddef import CardDef
@@ -15,6 +14,7 @@ from wcs.formdef import FormDef
 from wcs.qommon import ods
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
 from .utils import sign_uri
 
 

tests/api/test_formdata.py

@@ -12,7 +12,6 @@ import zipfile
 import pytest
 from django.utils.encoding import force_bytes
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.blocks import BlockDef
@@ -25,6 +24,7 @@ from wcs.qommon.ident.password_accounts import PasswordAccount
 from wcs.qommon.upload_storage import PicklableUpload
 from wcs.workflows import EditableWorkflowStatusItem, Workflow, WorkflowBackofficeFieldsFormDef
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .utils import sign_uri
 
 

tests/api/test_formdef.py

@@ -12,7 +12,6 @@ import mock
 import pytest
 from django.utils.encoding import force_text
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs import fields, qommon
 from wcs.api_utils import sign_url
@@ -23,6 +22,7 @@ from wcs.qommon.upload_storage import PicklableUpload
 from wcs.wf.jump import JumpWorkflowStatusItem
 from wcs.workflows import Workflow, WorkflowBackofficeFieldsFormDef
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
 from .utils import sign_uri
 
 

tests/api/test_user.py

@@ -5,7 +5,6 @@ import os
 
 import pytest
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs import fields
 from wcs.admin.settings import UserFieldsFormDef
@@ -15,6 +14,7 @@ from wcs.qommon.ident.password_accounts import PasswordAccount
 from wcs.qommon.upload_storage import PicklableUpload
 from wcs.workflows import Workflow, WorkflowVariablesFieldsFormDef
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
 from .utils import sign_uri
 
 

tests/api/test_utils.py

@@ -1,11 +1,12 @@
 import pytest
 from quixote import cleanup, get_response
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs import sessions
 from wcs.api_utils import get_query_flag
 from wcs.qommon.http_request import HTTPRequest
 
+from ..utilities import clean_temporary_pub, create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/api/test_workflow.py

@@ -4,7 +4,6 @@ import os
 
 import pytest
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs import fields
 from wcs.formdef import FormDef
@@ -14,6 +13,7 @@ from wcs.wf.jump import JumpWorkflowStatusItem
 from wcs.wf.register_comment import RegisterCommenterWorkflowStatusItem
 from wcs.workflows import Workflow
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app
 from .utils import sign_uri
 
 

tests/backoffice_pages/test_all.py

@@ -13,7 +13,6 @@ import mock
 import pytest
 from quixote import get_publisher
 from quixote.http_request import Upload as QuixoteUpload
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 import wcs.qommon.storage as st
 from wcs import fields
@@ -48,6 +47,8 @@ from wcs.workflows import (
 )
 from wcs.wscalls import NamedWsCall
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/backoffice_pages/test_carddata.py

@@ -4,7 +4,6 @@ import os
 import uuid
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -16,6 +15,7 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.wf.wscall import WebserviceCallStatusItem
 from wcs.workflows import ChoiceWorkflowStatusItem, Workflow
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_user
 
 

tests/backoffice_pages/test_custom_view.py

@@ -4,7 +4,6 @@ import re
 
 import pytest
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.carddef import CardDef
@@ -12,6 +11,7 @@ from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser, create_user
 
 

tests/backoffice_pages/test_export.py

@@ -9,7 +9,6 @@ import xml.etree.ElementTree as ET
 import zipfile
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.blocks import BlockDef
@@ -18,6 +17,7 @@ from wcs.qommon import ods
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.upload_storage import PicklableUpload
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser
 
 

tests/backoffice_pages/test_submission.py

@@ -6,7 +6,6 @@ import time
 import urllib.parse
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.api_utils import sign_url
@@ -18,6 +17,7 @@ from wcs.wf.jump import JumpWorkflowStatusItem
 from wcs.wf.redirect_to_url import RedirectToUrlWorkflowStatusItem
 from wcs.workflows import Workflow, WorkflowBackofficeFieldsFormDef
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_superuser, create_user
 
 

tests/conftest.py

@@ -2,7 +2,8 @@ import configparser
 import os
 
 import pytest
-from utilities import EmailsMocking, HttpRequestsMocking, SMSMocking
+
+from .utilities import EmailsMocking, HttpRequestsMocking, SMSMocking
 
 
 def site_options(request, pub, section, variable, value):

tests/form_pages/test_all.py

@@ -20,7 +20,6 @@ except ImportError:
     Image = None
 
 from django.utils.encoding import force_bytes, force_text
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.blocks import BlockDef
@@ -53,6 +52,8 @@ from wcs.workflows import (
     WorkflowVariablesFieldsFormDef,
 )
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def assert_equal_zip(stream1, stream2):
     z1 = zipfile.ZipFile(stream1)

tests/form_pages/test_block.py

@@ -5,7 +5,6 @@ import json
 
 import mock
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -16,6 +15,7 @@ from wcs.formdef import FormDef
 from wcs.wf.form import FormWorkflowStatusItem, WorkflowFormFieldsFormDef
 from wcs.workflows import Workflow
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_user
 
 

tests/form_pages/test_formdata.py

@@ -13,7 +13,6 @@ import mock
 import pytest
 from django.utils.encoding import force_bytes
 from quixote.http_request import Upload as QuixoteUpload
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Hidden, Upload
 
 from wcs import fields
@@ -33,6 +32,7 @@ from wcs.workflows import (
 )
 from wcs.wscalls import NamedWsCall
 
+from ..utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from .test_all import create_user, create_user_and_admin
 
 

tests/test_auth_pages.py

@@ -1,10 +1,11 @@
 import http.cookies
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 @pytest.fixture
 def pub():

tests/test_carddef.py

@@ -2,7 +2,6 @@ import io
 import xml.etree.ElementTree as ET
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs.carddef import CardDef
 from wcs.categories import CardDefCategory
@@ -11,6 +10,8 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.misc import indent_xml as indent
 from wcs.qommon.template import Template
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_categories.py

@@ -5,10 +5,11 @@ import shutil
 
 import pytest
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 from wcs.categories import CardDefCategory, Category
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_convert_to_sql.py

@@ -7,12 +7,13 @@ import pytest
 from django.core.management import call_command, get_commands
 from django.core.management.base import CommandError
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub, force_connections_close
 
 from wcs.fields import BoolField
 from wcs.formdef import FormDef
 from wcs.sql import cleanup_connection
 
+from .utilities import clean_temporary_pub, create_temporary_pub, force_connections_close
+
 
 @pytest.fixture
 def formdeffix():

tests/test_ctl.py

@@ -7,7 +7,6 @@ from email.mime.text import MIMEText
 import psycopg2
 import pytest
 from django.core.management import CommandError, call_command
-from utilities import clean_temporary_pub, create_temporary_pub
 
 import wcs.qommon.ctl
 from wcs.ctl.delete_tenant import CmdDeleteTenant
@@ -26,6 +25,8 @@ from wcs.sql import cleanup_connection, get_connection_and_cursor
 from wcs.wf.jump import JumpWorkflowStatusItem
 from wcs.workflows import Workflow, WorkflowStatusItem
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 @pytest.fixture
 def pub():

tests/test_datasource.py

@@ -8,14 +8,15 @@ import urllib.parse
 
 import mock
 import pytest
-from test_widgets import MockHtmlForm, mock_form_submission
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs import data_sources, fields
 from wcs.data_sources import NamedDataSource, register_data_source_function
 from wcs.qommon.form import Form, get_request
 from wcs.qommon.http_request import HTTPRequest
 
+from .test_widgets import MockHtmlForm, mock_form_submission
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_datasource_chrono.py

@@ -7,7 +7,6 @@ import shutil
 import mock
 import pytest
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 from wcs import fields
 from wcs.data_sources import NamedDataSource, build_agenda_datasources, collect_agenda_data
@@ -15,6 +14,8 @@ from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.misc import ConnectionError
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_ezt.py

@@ -4,7 +4,6 @@ import os
 
 import pytest
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs.qommon.ezt import (
     ArgCountSyntaxError,
@@ -16,6 +15,8 @@ from wcs.qommon.ezt import (
 )
 from wcs.scripts import ScriptsSubstitutionProxy
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app
+
 
 def setup_module(module):
     cleanup()

tests/test_fc_auth.py

@@ -5,7 +5,8 @@ import urllib.parse
 import mock
 from django.utils.encoding import force_bytes, force_text
 from quixote import cleanup, get_session_manager
-from utilities import create_temporary_pub, get_app
+
+from .utilities import create_temporary_pub, get_app
 
 PROFILE = {
     'fields': [

tests/test_fields.py

@@ -7,7 +7,6 @@ import pytest
 from bs4 import BeautifulSoup
 from quixote import cleanup
 from quixote.http_request import Upload
-from utilities import MockSubstitutionVariables, create_temporary_pub
 
 from wcs import fields
 from wcs.formdef import FormDef
@@ -17,6 +16,8 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.upload_storage import PicklableUpload
 from wcs.variables import LazyFormData
 
+from .utilities import MockSubstitutionVariables, create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_formdata.py

@@ -8,7 +8,6 @@ import mock
 import pytest
 from quixote import get_publisher
 from quixote.http_request import Upload
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs import fields, formdef, sessions
 from wcs.blocks import BlockDef
@@ -31,6 +30,8 @@ from wcs.workflows import (
     WorkflowStatusItem,
 )
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_formdef.py

@@ -11,7 +11,6 @@ import time
 import pytest
 from django.utils.encoding import force_bytes
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs import fields
 from wcs.blocks import BlockDef
@@ -22,6 +21,8 @@ from wcs.qommon.upload_storage import PicklableUpload
 from wcs.wf.form import FormWorkflowStatusItem, WorkflowFormFieldsFormDef
 from wcs.workflows import AttachmentEvolutionPart, Workflow, WorkflowBackofficeFieldsFormDef
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_formdef_import.py

@@ -7,7 +7,6 @@ import xml.etree.ElementTree as ET
 
 import pytest
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 from wcs.carddef import CardDef
 from wcs.categories import Category
@@ -15,6 +14,8 @@ from wcs.formdef import FormDef, FormdefImportError, fields
 from wcs.qommon.misc import indent_xml as indent
 from wcs.workflows import Workflow
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_hobo.py

@@ -12,13 +12,14 @@ import urllib.parse
 import mock
 import pytest
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs import fields, sql
 from wcs.ctl.check_hobos import CmdCheckHobos
 from wcs.publisher import WcsPublisher
 from wcs.qommon import force_str
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 HOBO_JSON = {
     'services': [
         {

tests/test_hobo_notify.py

@@ -2,13 +2,14 @@
 import uuid
 
 import pytest
-from utilities import create_temporary_pub
 
 from wcs.ctl.hobo_notify import CmdHoboNotify
 from wcs.qommon import force_str
 from wcs.qommon import storage as st
 from wcs.qommon.http_request import HTTPRequest
 
+from .utilities import create_temporary_pub
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_mail_templates.py

@@ -8,7 +8,6 @@ import xml.etree.ElementTree as ET
 import pytest
 from django.utils.encoding import force_bytes
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs.fields import FileField
@@ -19,6 +18,8 @@ from wcs.qommon.ident.password_accounts import PasswordAccount
 from wcs.qommon.upload_storage import PicklableUpload
 from wcs.workflows import SendmailWorkflowStatusItem, Workflow
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def setup_module(module):
     cleanup()

tests/test_misc.py

@@ -15,7 +15,6 @@ import pytest
 from django.core.cache import cache
 from django.utils import translation
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 import wcs.api  # workaround against circular dependencies :/
 import wcs.qommon.storage
@@ -43,6 +42,8 @@ from wcs.scripts import Script
 from wcs.wf.jump import JumpWorkflowStatusItem
 from wcs.workflows import Workflow
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app
+
 
 def setup_module(module):
     cleanup()

tests/test_prefill.py

@@ -3,12 +3,13 @@ import shutil
 
 import pytest
 from quixote import cleanup, get_request
-from utilities import create_temporary_pub
 
 from wcs import fields
 from wcs.carddef import CardDef
 from wcs.qommon.http_request import HTTPRequest
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_publisher.py

@@ -19,13 +19,14 @@ from django.http import Http404
 from django.test import override_settings
 from django.utils.encoding import force_text
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 from wcs.qommon import get_publisher_class
 from wcs.qommon.afterjobs import AfterJob
 from wcs.qommon.cron import CronJob
 from wcs.qommon.http_request import HTTPRequest
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_register.py

@@ -6,12 +6,13 @@ import shutil
 
 import pytest
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs.qommon import force_str
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_role.py

@@ -3,10 +3,11 @@
 import pickle
 
 from quixote import get_publisher
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs.roles import get_user_roles
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 def setup_module(module):
     pub = create_temporary_pub()

tests/test_rootdirectory.py

@@ -4,7 +4,6 @@ import sys
 
 import pytest
 from quixote import cleanup
-from utilities import create_temporary_pub, get_app
 
 import wcs.forms.root
 from wcs import formdef
@@ -13,6 +12,8 @@ from wcs.formdef import FormDef
 from wcs.qommon import sessions
 from wcs.qommon.http_request import HTTPRequest
 
+from .utilities import create_temporary_pub, get_app
+
 
 def setup_module(module):
     cleanup()

tests/test_saml2utils.py

@@ -1,11 +1,12 @@
 import shutil
 
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 from wcs.qommon import x509utils
 from wcs.qommon.saml2utils import Metadata
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_saml_auth.py

@@ -13,8 +13,6 @@ except ImportError:
 import pytest
 from quixote import cleanup, get_session, get_session_manager
 from quixote.errors import RequestError
-from test_hobo_notify import PROFILE
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs.qommon import sessions, x509utils
 from wcs.qommon.http_request import HTTPRequest
@@ -22,6 +20,9 @@ from wcs.qommon.ident.idp import AdminIDPDir, MethodAdminDirectory
 from wcs.qommon.misc import get_lasso_server
 from wcs.qommon.saml2 import Saml2Directory
 
+from .test_hobo_notify import PROFILE
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app
+
 pytestmark = pytest.mark.skipif('lasso is None')
 
 IDP_METADATA = """<?xml version="1.0"?>

tests/test_sessions.py

@@ -5,13 +5,14 @@ import time
 
 import pytest
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs import fields
 from wcs.formdef import FormDef
 from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.ident.password_accounts import PasswordAccount
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def setup_module():
     clean_temporary_pub()

tests/test_snapshots.py

@@ -4,9 +4,7 @@ import shutil
 import xml.etree.ElementTree as ET
 
 import pytest
-from admin_pages.test_all import create_role, create_superuser
 from quixote.http_request import Upload
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 
 from wcs.blocks import BlockDef
 from wcs.carddef import CardDef
@@ -20,6 +18,9 @@ from wcs.wf.form import FormWorkflowStatusItem, WorkflowFormFieldsFormDef
 from wcs.workflows import Workflow
 from wcs.wscalls import NamedWsCall
 
+from .admin_pages.test_all import create_role, create_superuser
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 @pytest.fixture
 def pub(request, emails):

tests/test_sql.py

@@ -13,7 +13,6 @@ import time
 import pytest
 from django.core.management import call_command
 from quixote import cleanup
-from utilities import clean_temporary_pub, create_temporary_pub
 
 import wcs.qommon.storage as st
 from wcs import fields, publisher, sql
@@ -24,6 +23,8 @@ from wcs.wf.jump import JumpWorkflowStatusItem
 from wcs.wf.register_comment import RegisterCommenterWorkflowStatusItem
 from wcs.workflows import CommentableWorkflowStatusItem, Workflow, WorkflowCriticalityLevel
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 postgresql = pytest.mark.postgresql
 
 try:

tests/test_storage.py

@@ -6,13 +6,14 @@ import time
 
 import pytest
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 import wcs.qommon.storage as st
 from wcs.carddef import CardDef
 from wcs.formdef import FormDef
 from wcs.qommon.storage import StorableObject, cache_umask
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_templates.py

@@ -13,7 +13,6 @@ except ImportError:
 
 from django.test import override_settings
 from django.utils.timezone import now
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs import fields
 from wcs.formdef import FormDef
@@ -22,6 +21,8 @@ from wcs.qommon.substitution import CompatibilityNamesDict
 from wcs.qommon.template import Template, TemplateError
 from wcs.variables import LazyFormData
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 @pytest.fixture
 def pub():

tests/test_texts.py

@@ -2,11 +2,12 @@ import shutil
 import sys
 
 from quixote import cleanup
-from utilities import MockSubstitutionVariables, create_temporary_pub
 
 from wcs.qommon.admin.texts import TextsDirectory
 from wcs.qommon.http_request import HTTPRequest
 
+from .utilities import MockSubstitutionVariables, create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_tracking_code.py

@@ -1,8 +1,9 @@
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs.formdef import FormDef
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_upload_storage.py

@@ -5,7 +5,6 @@ import os
 
 import mock
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app, login
 from webtest import Upload
 
 from wcs import fields
@@ -14,6 +13,8 @@ from wcs.formdef import FormDef
 from wcs.qommon.ident.password_accounts import PasswordAccount
 from wcs.wf.register_comment import RegisterCommenterWorkflowStatusItem
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app, login
+
 
 def pytest_generate_tests(metafunc):
     if 'pub' in metafunc.fixturenames:

tests/test_users.py

@@ -7,11 +7,12 @@ import time
 
 import pytest
 from quixote import cleanup
-from utilities import create_temporary_pub
 
 from wcs import fields, publisher
 from wcs.variables import LazyUser
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_variadic_url.py

@@ -1,9 +1,10 @@
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs.qommon.ezt import EZTException
 from wcs.qommon.misc import get_variadic_url
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 @pytest.fixture
 def pub(request):

tests/test_widgets.py

@@ -8,13 +8,14 @@ import mechanize
 import pytest
 from quixote import cleanup, get_response
 from quixote.http_request import parse_query
-from utilities import create_temporary_pub
 
 from wcs.qommon import sessions
 from wcs.qommon.form import *
 from wcs.qommon.http_request import HTTPRequest
 from wcs.wf.profile import ProfileUpdateRowWidget
 
+from .utilities import create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_workflow_import.py

@@ -5,7 +5,6 @@ import xml.etree.ElementTree as ET
 
 import pytest
 from quixote.http_request import Upload
-from utilities import clean_temporary_pub, create_temporary_pub
 
 from wcs.carddef import CardDef
 from wcs.fields import FileField, StringField
@@ -39,6 +38,8 @@ from wcs.workflows import (
     WorkflowVariablesFieldsFormDef,
 )
 
+from .utilities import clean_temporary_pub, create_temporary_pub
+
 
 @pytest.fixture
 def pub(request):

tests/test_workflows.py

@@ -19,7 +19,6 @@ except ImportError:
 from django.utils.encoding import force_bytes, force_text
 from quixote import cleanup, get_response
 from quixote.http_request import Upload as QuixoteUpload
-from utilities import MockSubstitutionVariables, clean_temporary_pub, create_temporary_pub
 
 from wcs import sessions
 from wcs.blocks import BlockDef
@@ -88,6 +87,8 @@ from wcs.workflows import (
     perform_items,
 )
 
+from .utilities import MockSubstitutionVariables, clean_temporary_pub, create_temporary_pub
+
 
 def setup_module(module):
     cleanup()

tests/test_wscall.py

@@ -1,7 +1,6 @@
 import json
 
 import pytest
-from utilities import clean_temporary_pub, create_temporary_pub, get_app
 
 from wcs import fields
 from wcs.formdef import FormDef
@@ -9,6 +8,8 @@ from wcs.qommon.http_request import HTTPRequest
 from wcs.qommon.template import Template
 from wcs.wscalls import NamedWsCall
 
+from .utilities import clean_temporary_pub, create_temporary_pub, get_app
+
 
 @pytest.fixture
 def pub():

tox.ini

@@ -45,5 +45,5 @@ deps =
     pre-commit
 commands =
     py.test -v {env:COVERAGE:} --junitxml=junit-{envname}.xml {posargs:tests/}
-    pylint: ./pylint.sh wcs/
+    pylint: ./pylint.sh wcs/ tests/
     codestyle: pre-commit run --all-files --show-diff-on-failure