forms: increase default textarea size (#17483)

tests/test_fields.py

@@ -58,6 +58,18 @@ def test_text():
     assert fields.TextField().get_view_value('foo\n\nfoo') == '<p>foo\n</p><p>\nfoo</p>'
     assert fields.TextField(pre=True).get_view_value('foo') == '<pre>foo</pre>'
 
+    form = Form(use_tokens=False)
+    fields.TextField().add_to_form(form)
+    assert '<textarea' in str(form.render())
+    assert 'cols="72"' in str(form.render())
+    assert 'rows="5"' in str(form.render())
+
+    form = Form(use_tokens=False)
+    fields.TextField(cols='12', rows='12').add_to_form(form)
+    assert '<textarea' in str(form.render())
+    assert 'cols="12"' in str(form.render())
+    assert 'rows="12"' in str(form.render())
+
 def test_email():
     assert fields.EmailField().get_view_value('foo@localhost') == \
             '<a href="mailto:foo@localhost">foo@localhost</a>'

wcs/qommon/form.py

@@ -194,6 +194,10 @@ def text_render_content(self):
         attrs['aria-required'] = 'true'
     if self.attrs:
         attrs.update(self.attrs)
+    if not attrs.get('cols'):
+        attrs['cols'] = 72
+    if not attrs.get('rows'):
+        attrs['rows'] = 5
     return (htmltag("textarea", name=self.name, **attrs) +
         htmlescape(self.value or "") + htmltext("</textarea>"))
 TextWidget.render_content = text_render_content