admin: don't display prefill option for backoffice fields (#11454)

tests/test_admin_pages.py

@@ -1718,6 +1718,10 @@ def test_workflows_backoffice_fields(pub):
     assert workflow.backoffice_fields_formdef.fields[0].id == 'bo1'
     assert workflow.backoffice_fields_formdef.fields[1].id == 'bo2'
 
+    # check there's no prefill field
+    resp = app.get('/backoffice/workflows/1/backoffice-fields/fields/bo2/')
+    assert not 'prefill$type' in resp.form.fields.keys()
+
     # add a title field
     resp = app.get('/backoffice/workflows/1/backoffice-fields/fields/')
     resp.forms[0]['label'] = 'foobar3'

wcs/admin/workflows.py

@@ -837,6 +837,11 @@ class WorkflowVariablesFieldDefPage(FieldDefPage):
 class WorkflowBackofficeFieldDefPage(FieldDefPage):
     section = 'workflows'
 
+    def form(self):
+        form = super(WorkflowBackofficeFieldDefPage, self).form()
+        form.remove('prefill')
+        return form
+
 
 class WorkflowVariablesFieldsDirectory(FieldsDirectory):
     _q_exports = ['', 'update_order', 'new']

wcs/qommon/form.py

@@ -295,8 +295,9 @@ class Form(QuixoteForm):
 
     def remove(self, name):
         widget = self._names.get(name)
-        del self._names[name]
-        self.widgets.remove(widget)
+        if widget:
+            del self._names[name]
+            self.widgets.remove(widget)
 
     def get_all_widgets(self):
         l = QuixoteForm.get_all_widgets(self)