notification: do not notify deleted user (#58647)

tests/workflow/test_all.py

@@ -5668,8 +5668,17 @@ def test_notifications(pub, http_requests):
         'summary': 'xxx',
     }
 
+    # deleted user
+    http_requests.empty()
+    user.deleted_timestamp = datetime.datetime.now()
+    user.store()
+    item.perform(formdata)
+    assert http_requests.count() == 0
+
     # roles (not exposed in current UI)
     http_requests.empty()
+    user.deleted_timestamp = datetime.datetime.now()
+    user.store()
 
     role = pub.role_class(name='blah')
     role.store()

wcs/wf/notification.py

@@ -160,7 +160,7 @@ class SendNotificationWorkflowStatusItem(WebserviceCallStatusItem):
                 users.extend(get_publisher().user_class.get_users_with_role(role.id))
 
         for user in users:
-            if not user or not user.is_active:
+            if not user or not user.is_active or user.deleted_timestamp:
                 continue
             for name_id in user.name_identifiers or []:
                 self.qs_data = {'NameID': name_id}