misc: ignore non-string criterias when looking for dependencies (#48363)

This commit is contained in:
Frédéric Péters 2020-11-06 14:43:34 +01:00
parent 7408d897e5
commit 4a24904f8f
2 changed files with 6 additions and 0 deletions

View File

@ -5986,6 +5986,10 @@ def test_dynamic_item_field_from_custom_view_on_cards(pub):
else:
assert resp.text.count('<tr') == 31 # thead + all items
resp.forms['listing-settings']['filter-0'].checked = True
resp.forms['listing-settings']['filter-status'].checked = True
resp = resp.forms['listing-settings'].submit()
resp.forms['listing-settings']['filter'].value = 'recorded'
resp = resp.forms['listing-settings'].submit()
resp.forms['save-custom-view']['title'] = 'as data source'

View File

@ -262,5 +262,7 @@ class CardDef(FormDef):
varnames = []
from .fields import Field
for criteria in cls.get_data_source_criterias(carddef, custom_view):
if not isinstance(criteria.value, str):
continue
varnames.extend(Field.get_referenced_varnames(formdef, criteria.value))
return varnames