tests: order logged errors when there are several of them (#59683)

This commit is contained in:
Frédéric Péters 2021-12-14 19:24:55 +01:00
parent 779c3e9cf7
commit 2d1034f4a9
4 changed files with 18 additions and 18 deletions

View File

@ -535,10 +535,10 @@ def test_data_source_custom_view_digest(pub):
assert [i['text'] for i in CardDef.get_data_source_items('carddef:foo:view')] == ['', '']
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[0]
logged_error = pub.loggederror_class.select(order_by='id')[0]
assert logged_error.summary == 'Digest (default) not defined'
assert logged_error.formdata_id == str(carddata2.id)
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.summary == 'Digest (custom view "view") not defined'
assert logged_error.formdata_id == str(carddata2.id)
assert CardDef.get_data_source_items('carddef:foo', get_by_text='') == []

View File

@ -156,7 +156,7 @@ def test_python_datasource_errors(pub, error_email, http_requests, emails, caplo
assert 'gave a non-iterable result' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.workflow_id is None
assert logged_error.summary == "[DATASOURCE] Python data source ('2') gave a non-iterable result"
@ -168,7 +168,7 @@ def test_python_datasource_errors(pub, error_email, http_requests, emails, caplo
assert data_sources.get_items(datasource) == []
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 3
logged_error = pub.loggederror_class.select()[2]
logged_error = pub.loggederror_class.select(order_by='id')[2]
assert logged_error.workflow_id is None
assert logged_error.summary == (
'[DATASOURCE] Python data source (\'[{"mairie-a-rdv", "Mairie A"}, {"mairie-b-rdv", "Mairie B"}]\') gave a non usable result'
@ -430,7 +430,7 @@ def test_json_datasource_bad_url(pub, error_email, http_requests, emails, caplog
assert 'Error reading JSON data source' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.workflow_id is None
assert (
logged_error.summary
@ -447,7 +447,7 @@ def test_json_datasource_bad_url(pub, error_email, http_requests, emails, caplog
assert 'Error loading JSON data source' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 3
logged_error = pub.loggederror_class.select()[2]
logged_error = pub.loggederror_class.select(order_by='id')[2]
assert logged_error.workflow_id is None
assert logged_error.summary == "[DATASOURCE] Error loading JSON data source (error)"
@ -461,7 +461,7 @@ def test_json_datasource_bad_url(pub, error_email, http_requests, emails, caplog
assert 'Error reading JSON data source output (err 1)' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 4
logged_error = pub.loggederror_class.select()[3]
logged_error = pub.loggederror_class.select(order_by='id')[3]
assert logged_error.workflow_id is None
assert logged_error.summary == "[DATASOURCE] Error reading JSON data source output (err 1)"
@ -495,7 +495,7 @@ def test_json_datasource_bad_url_scheme(pub, error_email, emails):
assert 'invalid scheme in URL' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.workflow_id is None
assert (
logged_error.summary
@ -852,7 +852,7 @@ def test_geojson_datasource_bad_url(pub, http_requests, error_email, emails):
assert 'Expecting value:' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.workflow_id is None
assert (
logged_error.summary
@ -870,7 +870,7 @@ def test_geojson_datasource_bad_url(pub, http_requests, error_email, emails):
assert 'error' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 3
logged_error = pub.loggederror_class.select()[2]
logged_error = pub.loggederror_class.select(order_by='id')[2]
assert logged_error.workflow_id is None
assert logged_error.summary == "[DATASOURCE] Error loading JSON data source (error)"
@ -884,7 +884,7 @@ def test_geojson_datasource_bad_url(pub, http_requests, error_email, emails):
assert 'Error reading JSON data source output (err 1)' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 4
logged_error = pub.loggederror_class.select()[3]
logged_error = pub.loggederror_class.select(order_by='id')[3]
assert logged_error.workflow_id is None
assert logged_error.summary == "[DATASOURCE] Error reading JSON data source output (err 1)"
@ -916,7 +916,7 @@ def test_geojson_datasource_bad_url_scheme(pub, error_email, emails):
assert 'invalid scheme in URL' in emails.get_latest('subject')
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.workflow_id is None
assert (
logged_error.summary

View File

@ -195,7 +195,7 @@ def test_fc_login_page(caplog):
)
)
if pub.is_using_postgresql():
assert 'user did not authorize login' in pub.loggederror_class.select()[-1].summary
assert 'user did not authorize login' in pub.loggederror_class.select(order_by='id')[-1].summary
resp = app.get(
'/ident/fc/callback?%s'
% urllib.parse.urlencode(
@ -206,7 +206,7 @@ def test_fc_login_page(caplog):
)
)
if pub.is_using_postgresql():
assert 'whatever' in pub.loggederror_class.select()[-1].summary
assert 'whatever' in pub.loggederror_class.select(order_by='id')[-1].summary
# Login existing user
def logme(login_url):

View File

@ -1275,7 +1275,7 @@ def test_lazy_formdata_queryset_filter(pub, variable_test_data):
assert queryset.count == 0
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.summary == 'Invalid value "not a date" for filter "datefield"'
if pub.is_using_postgresql():
@ -1296,7 +1296,7 @@ def test_lazy_formdata_queryset_filter(pub, variable_test_data):
queryset = lazy_formdata.objects.filter_by('datefield').apply_exclude_value('still not a date')
assert queryset.count == 0
assert pub.loggederror_class.count() == 3
logged_error = pub.loggederror_class.select()[2]
logged_error = pub.loggederror_class.select(order_by='id')[2]
assert logged_error.summary == 'Invalid value "still not a date" for filter "datefield"'
queryset = lazy_formdata.objects.filter_by('boolfield').apply_filter_value(True)
@ -1484,7 +1484,7 @@ def test_lazy_formdata_queryset_filter(pub, variable_test_data):
assert tmpl.render(context) == '0'
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 4
logged_error = pub.loggederror_class.select()[3]
logged_error = pub.loggederror_class.select(order_by='id')[3]
assert logged_error.summary == 'Invalid value "invalid value" for "filter_by_internal_id"'
# test |filter_by_number
@ -2599,7 +2599,7 @@ def test_form_digest_error(pub):
if pub.is_using_postgresql():
assert pub.loggederror_class.count() == 2
logged_error = pub.loggederror_class.select()[1]
logged_error = pub.loggederror_class.select(order_by='id')[1]
assert logged_error.summary == 'Could not render digest (custom view "foobar")'
assert logged_error.formdata_id == str(formdata.id)