misc: pylint fix wrong-import-position (#52222)

wcs/__init__.py

@@ -19,5 +19,5 @@ import sys
 
 sys.path.insert(0, os.path.dirname(__file__))
 
-from . import monkeypatch  # isort: skip
-from . import compat  # isort: skip
+from . import monkeypatch  # noqa isort: skip pylint: disable=C0413
+from . import compat  # noqa isort: skip pylint: disable=C0413

wcs/formdef.py

@@ -41,6 +41,7 @@ from .qommon import PICKLE_KWARGS
 from .qommon import _
 from .qommon import force_str
 from .qommon import get_cfg
+from .qommon.admin.emails import EmailsDirectory
 from .qommon.cron import CronJob
 from .qommon.form import *
 from .qommon.misc import get_as_datetime
@@ -1581,8 +1582,6 @@ class FormDef(StorableObject):
         return pickle.dumps(object, protocol=2) + pickle.dumps(object.fields, protocol=2)
 
 
-from .qommon.admin.emails import EmailsDirectory
-
 EmailsDirectory.register(
     'new_user',
     N_('Notification of creation to user'),

wcs/forms/root.py

@@ -43,6 +43,7 @@ from quixote.util import randbytes
 from wcs.categories import Category
 from wcs.formdata import FormData
 from wcs.formdef import FormDef
+from wcs.forms.common import FormStatusPage
 from wcs.forms.common import FormTemplateMixin
 from wcs.qommon.admin.texts import TextsDirectory
 from wcs.roles import logged_users_role
@@ -84,9 +85,6 @@ def get_user_forms(formdef):
     return list(user_forms)
 
 
-from wcs.forms.common import FormStatusPage
-
-
 def tryauth(url):
     # tries to log the user in before redirecting to the asked url; this won't
     # do anything for local logins but will use a passive SAML request when

wcs/publisher.py

@@ -36,11 +36,22 @@ try:
 except ImportError:
     pass
 
+import pickle
+
 from wcs.qommon import force_str
 
+from . import custom_views
+from . import sessions
+from .admin import RootDirectory as AdminRootDirectory
+from .backoffice import RootDirectory as BackofficeRootDirectory
+from .qommon.cron import CronJob
 from .qommon.publisher import QommonPublisher
 from .qommon.publisher import get_request
 from .qommon.publisher import set_publisher_class
+from .roles import Role
+from .root import RootDirectory
+from .tracking_code import TrackingCode
+from .users import User
 
 
 # this is terribly ugly but import RootDirectory will import a bunch of things,
@@ -52,19 +63,6 @@ class StubWcsPublisher(QommonPublisher):
 set_publisher_class(StubWcsPublisher)
 
 
-import pickle
-
-from . import custom_views
-from . import sessions
-from .admin import RootDirectory as AdminRootDirectory
-from .backoffice import RootDirectory as BackofficeRootDirectory
-from .qommon.cron import CronJob
-from .roles import Role
-from .root import RootDirectory
-from .tracking_code import TrackingCode
-from .users import User
-
-
 class UnpicklerClass(pickle.Unpickler):
     def find_class(self, module, name):
         if module == 'qommon.form':

wcs/qommon/__init__.py

@@ -55,10 +55,10 @@ def N_(x):
     return x
 
 
-from . import publisher
-from .publisher import get_cfg
-from .publisher import get_logger
-from .publisher import get_publisher_class
+from . import publisher  # noqa pylint: disable=C0413
+from .publisher import get_cfg  # noqa pylint: disable=C0413
+from .publisher import get_logger  # noqa pylint: disable=C0413
+from .publisher import get_publisher_class  # noqa pylint: disable=C0413
 
 publisher._ = _
 

wcs/workflows.py

@@ -3320,28 +3320,25 @@ register_item_class(EditableWorkflowStatusItem)
 
 def load_extra():
     from .wf import aggregation_email
-    from .wf import timeout_jump
-    from .wf import jump
-    from .wf import attachment
-    from .wf import remove
-    from .wf import roles
-    from .wf import dispatch
-    from .wf import geolocate
-    from .wf import wscall
-    from .wf import form
-    from .wf import register_comment
     from .wf import anonymise
-    from .wf import export_to_model
-    from .wf import resubmit
-    from .wf import criticality
-    from .wf import profile
+    from .wf import attachment
     from .wf import backoffice_fields
-    from .wf import redirect_to_url
-    from .wf import notification
-    from .wf import create_formdata
     from .wf import create_carddata
-    from .wf import external_workflow
+    from .wf import create_formdata
+    from .wf import criticality
+    from .wf import dispatch
     from .wf import edit_carddata
-
-
-from .wf.export_to_model import ExportToModel
+    from .wf import export_to_model
+    from .wf import external_workflow
+    from .wf import form
+    from .wf import geolocate
+    from .wf import jump
+    from .wf import notification
+    from .wf import profile
+    from .wf import redirect_to_url
+    from .wf import register_comment
+    from .wf import remove
+    from .wf import resubmit
+    from .wf import roles
+    from .wf import timeout_jump
+    from .wf import wscall

wcs/wsgi.py

@@ -3,8 +3,7 @@ WSGI config for wcs project.
 """
 import os
 
-os.environ.setdefault("DJANGO_SETTINGS_MODULE", "wcs.settings")
-
 from django.core.wsgi import get_wsgi_application
 
+os.environ.setdefault("DJANGO_SETTINGS_MODULE", "wcs.settings")
 application = get_wsgi_application()