Fixes #1874. Correctly error out when the user or the pass is not posted during login of CP.
This commit is contained in:
parent
02ed814162
commit
00eda3a2eb
|
@ -182,17 +182,20 @@ EOD;
|
|||
portal_reply_page($redirurl, "error", $errormsg);
|
||||
}
|
||||
|
||||
} else if ($_POST['accept'] && $config['captiveportal']['auth_method'] == "local") {
|
||||
} else if ($_POST['accept'] && $config['captiveportal']['auth_method'] == "local" && $_POST['auth_user']) {
|
||||
|
||||
if ($_POST['auth_user'] && $_POST['auth_pass']) {
|
||||
//check against local user manager
|
||||
$loginok = local_backed($_POST['auth_user'], $_POST['auth_pass']);
|
||||
if ($loginok){
|
||||
captiveportal_logportalauth($_POST['auth_user'],$clientmac,$clientip,"LOGIN");
|
||||
portal_allow($clientip, $clientmac,$_POST['auth_user']);
|
||||
} else {
|
||||
captiveportal_logportalauth($_POST['auth_user'],$clientmac,$clientip,"FAILURE");
|
||||
if ($loginok){
|
||||
captiveportal_logportalauth($_POST['auth_user'],$clientmac,$clientip,"LOGIN");
|
||||
portal_allow($clientip, $clientmac,$_POST['auth_user']);
|
||||
} else {
|
||||
captiveportal_logportalauth($_POST['auth_user'],$clientmac,$clientip,"FAILURE");
|
||||
portal_reply_page($redirurl, "error", $errormsg);
|
||||
}
|
||||
} else
|
||||
portal_reply_page($redirurl, "error", $errormsg);
|
||||
}
|
||||
} else if ($_POST['accept'] && $clientip && $config['captiveportal']['auth_method'] == "none") {
|
||||
captiveportal_logportalauth("unauthenticated",$clientmac,$clientip,"ACCEPT");
|
||||
portal_allow($clientip, $clientmac, "unauthenticated");
|
||||
|
|
Reference in New Issue