entrouvert
/
sentry-redmine
Archived
17
0
Fork 0
Code Issues Pull Requests Releases Activity

Merge pull request #4 from coagulant/patch-1 

Proper exception handling
This commit is contained in:
aaditya sood 2013-03-25 11:54:47 -07:00
parent 745ea54a60 d0b0639d97
commit 482250bb35
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sentry_redmine/plugin.py
View File

@ -109,15 +109,15 @@ class RedminePlugin(IssuePlugin):
try:
r = requests.post(url, data=json.dumps({'issue': payload}), headers=headers)
except requests.exceptions.HTTPError, e:
raise forms.ValidationError('Unable to reach Redmine host: %s' % (e.reason,))
except requests.exceptions.HTTPError as e:
raise forms.ValidationError('Unable to reach Redmine host: %s' % repr(e))
try:
data = json.loads(r.text)
except json.JSONDecodeError, e:
except json.JSONDecodeError as e:
#print >> sys.stderr, "ERROR: %s" % e
#print >> sys.stderr, "RESP:", r.text
raise forms.ValidationError('Unable to reach Redmine host: %s' % (e.reason,))
raise forms.ValidationError('Unable to reach Redmine host: %s' % repr(e))
if not 'issue' in data or not 'id' in data['issue']:
raise forms.ValidationError('Unable to create redmine ticket')