lille urban card: change card info endpoint to use GET (#51121)

This commit is contained in:
Frédéric Péters 2021-02-15 13:50:14 +01:00
parent 3ddf46eff1
commit e41eabb5f8
2 changed files with 9 additions and 8 deletions

View File

@ -222,12 +222,13 @@ class LilleUrbanCard(BaseResource):
raise APIError(response_json[error_attribute], data=response_json)
raise APIError('invalid response', data=response_json)
@endpoint(perm='can_access', description=_('Get Card Info'), methods=['post'])
def card_info(self, request, *args, **kwargs):
data = json_loads(request.body)
numero_serie = data.get('numero_serie')
if not numero_serie:
raise APIError('missing numero serie')
@endpoint(perm='can_access', description=_('Get Card Info'),
parameters={
'numero_serie': {
'description': _('Serial Number'),
}
})
def card_info(self, request, numero_serie, **kwargs):
response = self.requests.get(
urljoin(self.base_url, '/clu/ws/consulterCarte?numero_serie=%s' % numero_serie),
auth=HttpBearerAuth(self.get_token()))

View File

@ -247,13 +247,13 @@ def test_code_check(app, connector):
def test_card_info(app, connector):
endpoint = utils.generic_endpoint_url('lille-urban-card', 'card_info', slug=connector.slug)
with HTTMock(mocked_http):
resp = app.post_json(endpoint, params={
resp = app.get(endpoint, params={
'numero_serie': 'XXX',
})
assert resp.json['err'] == 0
# error handling
resp = app.post_json(endpoint, params={
resp = app.get(endpoint, params={
'numero_serie': 'ERROR',
}, status=200)
assert resp.json['err'] == 1