tests: remove test declared xfail (#73760)

tests/test_misc.py

@@ -1,13 +1,9 @@
 import datetime
-from io import StringIO
 from unittest import mock
 from unittest.mock import patch
 
 import pytest
 from django.contrib.contenttypes.models import ContentType
-from django.core.files import File
-from django.db import connection
-from django.db.migrations.executor import MigrationExecutor
 from django.urls import reverse
 from django.utils import timezone
 from requests.exceptions import ReadTimeout
@@ -140,44 +136,6 @@ def test_trace_emails(app, settings, dummy_csv_datasource, email_handler, mailou
         assert mailoutbox[idx].to == ['john.doe@example.net']
 
 
-@pytest.mark.xfail
-def test_jsonb_migration(transactional_db):
-    app = 'csvdatasource'
-
-    migrate_from = [(app, '0017_auto_20200504_1402')]
-    migrate_to = [(app, '0018_text_to_jsonb')]
-    executor = MigrationExecutor(connection)
-    old_apps = executor.loader.project_state(migrate_from).apps
-    # state of the db is not important
-    executor.migrate(migrate_from, fake=True)
-
-    data = {'data': {'test': 1}}
-    CsvDataSource = old_apps.get_model(app, 'CsvDataSource')
-    connector = CsvDataSource.objects.create(csv_file=File(StringIO(''), 't.csv'), _dialect_options=data)
-    pk = connector.pk
-
-    field = CsvDataSource._meta.get_field('_dialect_options')
-    with connection.cursor() as cursor:
-        cursor.execute(
-            'ALTER TABLE {table} ALTER COLUMN {col} TYPE text USING {col}::text;'.format(
-                table=CsvDataSource._meta.db_table, col=field.get_attname_column()[1]
-            )
-        )
-    connector = CsvDataSource.objects.get(pk=pk)
-    # db is in a broken state
-    assert connector._dialect_options != data
-
-    # ensure migration fixes it
-    executor = MigrationExecutor(connection)
-    executor.migrate(migrate_to)
-    executor.loader.build_graph()
-
-    apps = executor.loader.project_state(migrate_to).apps
-    CsvDataSource = apps.get_model(app, 'CsvDataSource')
-    connector = CsvDataSource.objects.get(pk=pk)
-    assert connector._dialect_options == data
-
-
 def test_check_status_no_traceback_email(db, settings, email_handler, mailoutbox):
     settings.ADMINS = [('admin', 'admin@example.net')]
     connector = BaseAdresse.objects.create(slug='base-adresse')