lille urban card: do not transmit requests with empty/none serial (#54613)

passerelle/contrib/lille_urban_card/models.py

@@ -240,6 +240,8 @@ class LilleUrbanCard(BaseResource):
         },
     )
     def card_info(self, request, numero_serie, **kwargs):
+        if not numero_serie or numero_serie == 'None':
+            raise APIError('missing numero_serie')
         response = self.requests.get(
             urljoin(self.base_url, '/clu/ws/consulterCarte?numero_serie=%s' % numero_serie),
             auth=HttpBearerAuth(self.get_token()),

tests/test_lille_urban_card.py

@@ -296,6 +296,15 @@ def test_card_info(app, connector):
         )
         assert resp.json['err'] == 1
 
+    # empty numero_serie, do not even pass request
+    resp = app.get(
+        endpoint,
+        params={
+            'numero_serie': '',
+        },
+    )
+    assert resp.json['err'] == 1
+
 
 def test_card_revocation(app, connector):
     endpoint = utils.generic_endpoint_url('lille-urban-card', 'card_revocation', slug=connector.slug)