entrouvert
/
lingo
15
0
Fork 0
Code Issues Pull Requests 8 Releases Wiki Activity

invoicing: don't delete cancellation reason used on credit (#89810)
gitea/lingo/pipeline/head This commit looks good Details

This commit is contained in:
Lauréline Guérin 2024-04-23 13:32:16 +02:00
parent 904203c808
commit 3b3dcf1c7f
No known key found for this signature in database
GPG Key ID: 1FAB9B9B4F93D473
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lingo/invoicing/templates/lingo/invoicing/manager_cancellation_reason_list.html
View File

@ -27,7 +27,7 @@
{% for reason in invoice_reason_list %}
<li>
<a href="{% url 'lingo-manager-invoicing-invoice-cancellation-reason-edit' reason.pk %}">{{ reason }}{% if reason.disabled %}<span class="extra-info"> ({% trans "disabled" %})</span>{% endif %}</a>
{% if not reason.invoice_set.exists %}
{% if not reason.invoice_set.exists and not reason.credit_set.exists %}
<a class="delete" rel="popup" href="{% url 'lingo-manager-invoicing-invoice-cancellation-reason-delete' reason.pk %}">{% trans "delete"%}</a>
{% endif %}
</li>

2
lingo/invoicing/views/cancellation_reason.py
View File

@ -66,7 +66,7 @@ class InvoiceReasonDeleteView(DeleteView):
model = InvoiceCancellationReason
def get_queryset(self):
return InvoiceCancellationReason.objects.filter(invoice__isnull=True)
return InvoiceCancellationReason.objects.filter(invoice__isnull=True, credit__isnull=True)
def get_success_url(self):
return '%s#open:invoice' % reverse('lingo-manager-invoicing-cancellation-reason-list')

13
tests/invoicing/manager/test_cancellation_reason.py
View File

@ -3,6 +3,7 @@ import datetime
import pytest
from lingo.invoicing.models import (
Credit,
Invoice,
InvoiceCancellationReason,
Payment,
@ -82,6 +83,18 @@ def test_delete_invoice_reason(app, admin_user):
invoice.delete()
credit = Credit.objects.create(
regie=regie,
date_publication=datetime.date(2023, 4, 21),
cancellation_reason=invoice_reason,
)
resp = app.get('/manage/invoicing/cancellation-reasons/')
assert '/manage/invoicing/cancellation-reason/invoice/%s/delete/' % invoice_reason.pk not in resp
app.get('/manage/invoicing/cancellation-reason/invoice/%s/delete/' % invoice_reason.pk, status=404)
credit.delete()
resp = app.get('/manage/invoicing/cancellation-reasons/')
resp = resp.click(href='/manage/invoicing/cancellation-reason/invoice/%s/delete/' % invoice_reason.pk)
resp = resp.form.submit()