entrouvert
/
lasso
16
0
Fork 0
Code Issues Pull Requests Releases Activity

ID-FF 1.2: Add handling of relaystate for logout requests 

* lasso/id-ff/logout.c (lasso_logout_process_request_msg,
 lasso_logout_validate_request): transfer relaystate from request
 message to profile field.
This commit is contained in:
Benjamin Dauvergne 2009-03-27 15:06:23 +00:00
parent 854df3b651
commit c89c77c924
2 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lasso/id-ff/defederation.c
View File

@ -339,7 +339,7 @@ lasso_defederation_process_notification_msg(LassoDefederation *defederation, cha
/* get the RelayState (only available in redirect mode) */
if (LASSO_LIB_FEDERATION_TERMINATION_NOTIFICATION(profile->request)->RelayState)
lasso_assign_string(profile->msg_relayState.
lasso_assign_string(profile->msg_relayState,
LASSO_LIB_FEDERATION_TERMINATION_NOTIFICATION(
profile->request)->RelayState);

26
lasso/id-ff/logout.c
View File

@ -545,16 +545,14 @@ lasso_logout_process_request_msg(LassoLogout *logout, char *request_msg)
logout_request = LASSO_LIB_LOGOUT_REQUEST(profile->request);
/* Validate some schema constraints */
if (LASSO_LIB_LOGOUT_REQUEST(profile->request)->ProviderID == NULL
if (logout_request->ProviderID == NULL
|| LASSO_IS_SAML_NAME_IDENTIFIER(logout_request->NameIdentifier) == FALSE) {
return critical_error(LASSO_PROFILE_ERROR_INVALID_MSG);
}
if (profile->remote_providerID) {
g_free(profile->remote_providerID);
}
lasso_assign_string(profile->msg_relayState,
logout_request->RelayState);
lasso_assign_string(profile->remote_providerID,
LASSO_LIB_LOGOUT_REQUEST(profile->request)->ProviderID);
logout_request->ProviderID);
remote_provider = g_hash_table_lookup(profile->server->providers,
profile->remote_providerID);
@ -572,7 +570,7 @@ lasso_logout_process_request_msg(LassoLogout *logout, char *request_msg)
profile->http_request_method = LASSO_HTTP_METHOD_REDIRECT;
lasso_assign_gobject(profile->nameIdentifier,
LASSO_LIB_LOGOUT_REQUEST(profile->request)->NameIdentifier);
logout_request->NameIdentifier);
return profile->signature_status;
}
@ -827,6 +825,7 @@ lasso_logout_validate_request(LassoLogout *logout)
LassoSamlNameIdentifier *nameIdentifier;
LassoSamlAssertion *assertion;
LassoNode *assertion_n;
LassoLibLogoutRequest *logout_request = NULL;
g_return_val_if_fail(LASSO_IS_LOGOUT(logout), LASSO_PARAM_ERROR_BAD_TYPE_OR_NULL_OBJ);
@ -840,9 +839,10 @@ lasso_logout_validate_request(LassoLogout *logout)
if (LASSO_IS_LIB_LOGOUT_REQUEST(profile->request) == FALSE) {
return LASSO_PROFILE_ERROR_MISSING_REQUEST;
}
logout_request = LASSO_LIB_LOGOUT_REQUEST(profile->request);
lasso_assign_string(profile->remote_providerID,
LASSO_LIB_LOGOUT_REQUEST(profile->request)->ProviderID);
logout_request->ProviderID);
/* get the provider */
remote_provider = g_hash_table_lookup(profile->server->providers,
@ -857,7 +857,7 @@ lasso_logout_validate_request(LassoLogout *logout)
lasso_assign_gobject(profile->response, lasso_lib_logout_response_new_full(
LASSO_PROVIDER(profile->server)->ProviderID,
LASSO_SAML_STATUS_CODE_SUCCESS,
LASSO_LIB_LOGOUT_REQUEST(profile->request),
logout_request,
profile->server->certificate ?
LASSO_SIGNATURE_TYPE_WITHX509 : LASSO_SIGNATURE_TYPE_SIMPLE,
LASSO_SIGNATURE_METHOD_RSA_SHA1));
@ -866,7 +866,7 @@ lasso_logout_validate_request(LassoLogout *logout)
lasso_assign_gobject(profile->response, lasso_lib_logout_response_new_full(
LASSO_PROVIDER(profile->server)->ProviderID,
LASSO_SAML_STATUS_CODE_SUCCESS,
LASSO_LIB_LOGOUT_REQUEST(profile->request),
logout_request,
LASSO_SIGNATURE_TYPE_NONE,
0));
}
@ -874,6 +874,10 @@ lasso_logout_validate_request(LassoLogout *logout)
return critical_error(LASSO_PROFILE_ERROR_BUILDING_RESPONSE_FAILED);
}
/* copy the RelayState */
lasso_assign_string(LASSO_LIB_STATUS_RESPONSE(profile->response)->RelayState,
profile->msg_relayState);
/* Verify signature status, if signature is invalid, stop validation here */
if (profile->signature_status != 0) {
lasso_profile_set_response_status(profile,
@ -882,7 +886,7 @@ lasso_logout_validate_request(LassoLogout *logout)
}
/* Get the name identifier */
nameIdentifier = LASSO_LIB_LOGOUT_REQUEST(profile->request)->NameIdentifier;
nameIdentifier = logout_request->NameIdentifier;
if (nameIdentifier == NULL) {
message(G_LOG_LEVEL_CRITICAL, "Name identifier not found in logout request");
lasso_profile_set_response_status(