check tracker id using correct attribute (#78352)
gitea/gitea-redmine/pipeline/head This commit looks good Details

This commit is contained in:
Frédéric Péters 2023-06-12 13:06:34 +02:00
parent 001c6f650d
commit 2c54d760d1
2 changed files with 6 additions and 3 deletions

View File

@ -205,8 +205,12 @@ def set_status(status_id, unless=[]):
def inner(issue, payload):
current_status = issue.status.id
if current_status not in unless:
if issue.tracker_id not in list(REDMINE_TRACKERS.values()):
if issue.tracker.id not in list(REDMINE_TRACKERS.values()):
issue.tracker_id = REDMINE_TRACKERS['Développement']
else:
# always assigne value, to get tracker_id attribute on the object
# for the unit tests.
issue.tracker_id = issue.tracker.id
issue.status_id = status_id
return inner

View File

@ -119,8 +119,7 @@ def test_handle_pull_request_opened(current_tracker_id, expected_tracker_id, moc
}
project = mocker.Mock()
project.parent = None
issue = mocker.Mock()
issue.tracker_id = current_tracker_id
issue = mocker.Mock(tracker=mocker.Mock(id=current_tracker_id))
gitea_redmine.handle_pull_request_opened(issue, payload, project)
get_redmine_user.assert_called_once_with('testuser')