entrouvert
/
fargo
17
0
Fork 0
Code Issues Pull Requests 1 Releases Activity

fix typo "attachement" -> "attachment" (fixes #22676)

This commit is contained in:
Benjamin Dauvergne 2018-03-21 14:47:25 +01:00
parent b962eb7d5d
commit d780a085a9
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fargo/oauth2/utils.py
View File

@ -25,8 +25,8 @@ def get_content_disposition_value(request):
return None, 'missing content-disposition header'
content_header = request.META['HTTP_CONTENT_DISPOSITION']
disposition_type, filename = cgi.parse_header(content_header)
if disposition_type != 'attachement':
return None, 'wrong disposition type: attachement excpected'
if disposition_type != 'attachment':
return None, 'wrong disposition type: attachment excpected'
if 'filename*' in filename:
encode, country, name = filename['filename*'].split("'")

4
fargo/oauth2/views.py
View File

@ -143,8 +143,8 @@ def get_document(request):
ascii_filename = doc.filename.encode('ascii', 'replace')
percent_encoded_filename = quote(doc.filename.encode('utf8'), safe='')
response['Content-Disposition'] = 'attachement; filename="%s"; filename*=UTF-8\'\'%s' % (ascii_filename,
percent_encoded_filename)
response['Content-Disposition'] = 'attachment; filename="%s"; filename*=UTF-8\'\'%s' % (ascii_filename,
percent_encoded_filename)
return response

4
tests/test_oauth2.py
View File

@ -107,7 +107,7 @@ def test_get_document_oauth2(app, john_doe, oauth2_client, user_doc):
assert resp.content_type == 'application/octet-stream'
assert 'Content-disposition' in resp.headers
content_disposition = resp.content_disposition.replace(' ', '').split(';')
assert content_disposition[0] == 'attachement'
assert content_disposition[0] == 'attachment'
assert content_disposition[1] == 'filename="Baudelaire.txt"'
assert content_disposition[2] == 'filename*=UTF-8\'\'Baudelaire.txt'
@ -127,7 +127,7 @@ def test_put_document(app, john_doe, oauth2_client):
filename = 'Baudelaire.txt'.encode('ascii', 'replace')
percent_encode_filename = quote(filename.encode('utf8'), safe='')
headers = {
'Content-disposition': 'attachement; filename="%s"; filename*=UTF-8\'\'%s' % (filename, percent_encode_filename)
'Content-disposition': 'attachment; filename="%s"; filename*=UTF-8\'\'%s' % (filename, percent_encode_filename)
}
assert len(OAuth2TempFile.objects.all()) == 0