📚 update PR guide
This commit is contained in:
parent
89f53f51a4
commit
12f12346cb
|
@ -0,0 +1,10 @@
|
|||
With your PR, here is a check list:
|
||||
|
||||
- [ ] Has Test cases written
|
||||
- [ ] Has all code lines tested
|
||||
- [ ] Passes all Travis CI builds
|
||||
- [ ] Has fair amount of documentation if your change is complex
|
||||
- [ ] run 'make format' so as to confirm the pyexcel organisation's coding style
|
||||
- [ ] Please update CHANGELOG.rst
|
||||
- [ ] Please add yourself to CONTRIBUTORS.rst
|
||||
- [ ] Agree on NEW BSD License for your contribution
|
|
@ -22,3 +22,4 @@ targets:
|
|||
template: CHANGELOG.rst.jj2
|
||||
- lint.sh: lint.script.jj2
|
||||
- ".github/FUNDING.yml": "FUNDING.yml"
|
||||
- ".github/PULL_REQUEST_TEMPLATE.md": PULL_REQUEST_TEMPLATE.md
|
||||
|
|
12
README.rst
12
README.rst
|
@ -209,18 +209,6 @@ What is .moban.d
|
|||
|
||||
`.moban.d` stores the specific meta data for the library.
|
||||
|
||||
Acceptance criteria
|
||||
-------------------
|
||||
|
||||
#. Has Test cases written
|
||||
#. Has all code lines tested
|
||||
#. Passes all Travis CI builds
|
||||
#. Has fair amount of documentation if your change is complex
|
||||
#. run 'make format' so as to confirm the pyexcel organisation's coding style
|
||||
#. Please update CHANGELOG.rst
|
||||
#. Please add yourself to CONTRIBUTORS.rst
|
||||
#. Agree on NEW BSD License for your contribution
|
||||
|
||||
|
||||
|
||||
License
|
||||
|
|
Loading…
Reference in New Issue