history: check if page exists (#41246)

combo/manager/views.py

@@ -402,9 +402,10 @@ class PageHistoryView(ListView):
     paginate_by = 20
 
     def get_queryset(self):
-        self.page = Page.objects.get(id=self.kwargs['pk'])
+        self.page = get_object_or_404(Page, pk=self.kwargs['pk'])
         return self.page.pagesnapshot_set.all()
 
+
 page_history = PageHistoryView.as_view()
 
 

tests/test_manager.py

@@ -1614,6 +1614,9 @@ def test_page_versionning(app, admin_user):
     assert TextCell.objects.count() == 3
     assert JsonCell.objects.count() == 0
 
+    # page does not exists
+    app.get('/manage/pages/0/history', status=404)
+
 
 def test_view_old_snapshot(app, admin_user):
     page = Page.objects.create(title='One', slug='one')