misc: fix expression-not-assigned pylint error (#56288)

tests/test_import_export.py

@@ -388,7 +388,7 @@ def test_import_export_tar(tmpdir, some_assets):
     call_command('import_site', filename)  # default behaviour
     assert Page.objects.count() == 1
     assert Asset.objects.count() == 3
-    Asset.objects.get(key='banner').asset.name == 'assets/test.png'
+    assert Asset.objects.get(key='banner').asset.name == 'assets/test.png'
     with open('%s/assets/test.png' % default_storage.path('')) as fd:
         assert fd.read() == 'original content'
 
@@ -396,7 +396,7 @@ def test_import_export_tar(tmpdir, some_assets):
     call_command('import_site', filename, '--overwrite')
     assert Page.objects.count() == 1
     assert Asset.objects.count() == 3
-    Asset.objects.get(key='banner').asset.name == 'assets/test.png'
+    assert Asset.objects.get(key='banner').asset.name == 'assets/test.png'
     with open('%s/assets/test.png' % default_storage.path('')) as fd:
         assert fd.read() == 'test'
 
@@ -404,17 +404,17 @@ def test_import_export_tar(tmpdir, some_assets):
     call_command('import_site', filename, '--if-empty')
     assert Page.objects.count() == 1
     assert Asset.objects.count() == 2
-    Asset.objects.get(key='banner').asset.name == 'assets/test3.png'
+    assert Asset.objects.get(key='banner').asset.name == 'assets/test.png'
     with open('%s/assets/test.png' % default_storage.path('')) as fd:
         assert fd.read() == 'original content'
-    Asset.objects.get(key='logo').asset.name == 'assets/logo.png'
+    assert Asset.objects.get(key='logo').asset.name == 'assets/logo.png'
     assert os.path.isfile('%s/assets/logo.png' % default_storage.path(''))
 
     populate_site()
     call_command('import_site', filename, '--clean')
     assert Page.objects.count() == 0
     assert Asset.objects.count() == 2
-    Asset.objects.get(key='banner').asset.name == 'assets/test.png'
+    assert Asset.objects.get(key='banner').asset.name == 'assets/test.png'
     with open('%s/assets/test.png' % default_storage.path('')) as fd:
         assert fd.read() == 'test'
     assert not Asset.objects.filter(key='logo')

tests/test_lingo_manager.py

@@ -682,6 +682,6 @@ def test_edit_payment_backend_validation(app, admin_user):
 
 
 def test_use_old_service_options_safely(app, admin_user):
-    PaymentBackend(service='dummy', service_options='xx').eopayment
-    PaymentBackend(service='dummy', service_options='"xx"').eopayment
-    PaymentBackend(service='dummy', service_options=None).eopayment
+    assert PaymentBackend(service='dummy', service_options='xx').eopayment
+    assert PaymentBackend(service='dummy', service_options='"xx"').eopayment
+    assert PaymentBackend(service='dummy', service_options=None).eopayment

tests/test_public.py

@@ -869,7 +869,7 @@ def test_familyinfos_cell_with_placeholders(app, admin_user):
             )
             # make sure no data are loaded
             resp = app.get('/')
-            resp.html.body.find('div', {'class': 'familyinfoscell'}).text.strip() == 'Loading...'
+            assert resp.html.body.find('div', {'class': 'familyinfoscell'}).text.strip() == 'Loading...'
             # put data in cache
             resp = app.get(
                 reverse(