pylint: discard frowned-upon uses of dict.keys() (#57044)

combo/manager/views.py

@@ -370,7 +370,7 @@ class PageView(ManagedPageMixin, DetailView):
             cell_type_groups[cell_type['group']].append(cell_type)
         for cell_group in cell_type_groups.values():
             cell_group.sort(key=lambda x: (x.get('order'), x.get('name')))
-        if 'data' in cell_type_groups.keys():
+        if 'data' in cell_type_groups:
             cell_type_groups[''] = cell_type_groups.get('data')
             del cell_type_groups['data']
         context['cell_type_groups'] = list(cell_type_groups.items())

tests/test_search.py

@@ -874,7 +874,7 @@ def test_wcs_search_engines(settings, app):
             page.save()
             search_engines = engines.get_engines()
             assert len([x for x in search_engines if x.startswith('cards:')]) == 1
-            assert 'cards:c21f969b:card-bar' in search_engines.keys()
+            assert 'cards:c21f969b:card-bar' in search_engines
             card_engine = search_engines['cards:c21f969b:card-bar']
             assert card_engine['url'] == (
                 'http://127.0.0.1:8999/api/cards/card-bar/list/'
@@ -1112,20 +1112,20 @@ def test_wcs_search_cell(requests_get, mock_wcs, settings, app):
 def test_profile_search_engines(settings, app):
     settings.KNOWN_SERVICES = {}
     search_engines = engines.get_engines()
-    assert 'users' not in search_engines.keys()
+    assert 'users' not in search_engines
 
     settings.KNOWN_SERVICES = {'authentic': {'default': {'title': 'authentic', 'url': 'https://authentic/'}}}
     search_engines = engines.get_engines()
-    assert 'users' not in search_engines.keys()
+    assert 'users' not in search_engines
 
     page = Page.objects.create(slug='users', title='Users', sub_slug='(?P<name_id>[a-z0-9]+)')
     search_engines = engines.get_engines()
-    assert 'users' in search_engines.keys()
+    assert 'users' in search_engines
 
     page.sub_slug = 'name_id'
     page.save()
     search_engines = engines.get_engines()
-    assert 'users' in search_engines.keys()
+    assert 'users' in search_engines
 
 
 def test_profile_add_search_engines(settings, app, admin_user):

tests/test_wcs.py

@@ -2219,11 +2219,11 @@ def test_tracking_code_search_rate_limit(settings, app):
 def test_wcs_search_engines(app):
     settings.TEMPLATE_VARS['is_portal_agent'] = True
     search_engines = engines.get_engines()
-    assert 'tracking-code' in search_engines.keys()
+    assert 'tracking-code' in search_engines
     assert len([x for x in search_engines if x.startswith('formdata:')]) == 2
     settings.TEMPLATE_VARS['is_portal_agent'] = False
     search_engines = engines.get_engines()
-    assert 'tracking-code' not in search_engines.keys()
+    assert 'tracking-code' not in search_engines
     assert len([x for x in search_engines if x.startswith('formdata:')]) == 0