entrouvert
/
combo
16
1
Fork 0
Code Issues Pull Requests 12 Releases Wiki Activity

dataviz: change message when page variable cannot be evaluated (#68372)

This commit is contained in:
Valentin Deniaud 2022-08-23 16:53:37 +02:00 committed by Frédéric Péters
parent d1b26246b7
commit 4192343b05
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
combo/apps/dataviz/views.py
View File

@ -82,7 +82,7 @@ class DatavizGraphView(DetailView):
except TemplateSyntaxError:
return self.error(_('Syntax error in page variable.'))
except VariableDoesNotExist:
return self.error(_('Cannot evaluate page variable.'))
return self.error(_('Backoffice preview unavailable.'))
except HTTPError as e:
if e.response.status_code == 404:
return self.error(_('Visualization not found.'))

4
tests/test_dataviz.py
View File

@ -2131,7 +2131,7 @@ def test_chartng_cell_new_api_filter_params_page_variables(app, admin_user, new_
resp = app.get(location)
assert len(new_api_mock.call['requests']) == 2
assert 'Cannot evaluate page variable.' in resp.text
assert 'Backoffice preview unavailable.' in resp.text
# simulate call from page view
app = login(app)
@ -2190,7 +2190,7 @@ def test_chartng_cell_new_api_filter_params_page_variables_table(new_api_statist
resp = app.get(location)
assert len(new_api_mock.call['requests']) == 1
assert 'Cannot evaluate page variable.' in resp.text
assert 'Backoffice preview unavailable.' in resp.text
def test_dataviz_check_validity(nocache):