entrouvert
/
combo
16
1
Fork 0
Code Issues Pull Requests 12 Releases Wiki Activity

dataviz: catch invalid template error when updating subfilters (#65916)

This commit is contained in:
Valentin Deniaud 2022-06-02 15:03:30 +02:00
parent c25139c7d8
commit 17fb7f22e6
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
combo/apps/dataviz/models.py
View File

@ -717,7 +717,11 @@ class ChartNgCell(CellBase):
def update_subfilters(self):
self._request = get_request()
response = self.get_statistic_data()
try:
response = self.get_statistic_data()
except (TemplateSyntaxError, VariableDoesNotExist):
return
try:
response.raise_for_status()
data = response.json()['data']

7
tests/test_dataviz.py
View File

@ -2625,3 +2625,10 @@ def test_chartng_cell_subfilter_page_variable(new_api_statistics, app, admin_use
resp.form[field_prefix + 'form'] = 'food-request'
manager_submit_cell(resp.form)
assert field_prefix + 'menu' in resp.form.fields
# page variable has syntax error
page.extra_variables = {'foo': '{% for %}'}
page.save()
resp.form[field_prefix + 'form'] = 'contact'
manager_submit_cell(resp.form)
assert field_prefix + 'menu' in resp.form.fields