export_import: unknown component_type in urls (#88068)

chrono/apps/export_import/api_views.py

@@ -52,6 +52,13 @@ compare_urls = {
 }
 
 
+def get_klass_from_component_type(component_type):
+    try:
+        return klasses[component_type]
+    except KeyError:
+        raise Http404
+
+
 class Index(GenericAPIView):
     permission_classes = (permissions.IsAdminUser,)
 
@@ -150,7 +157,7 @@ class ListComponents(GenericAPIView):
     permission_classes = (permissions.IsAdminUser,)
 
     def get(self, request, *args, **kwargs):
-        klass = klasses[kwargs['component_type']]
+        klass = get_klass_from_component_type(kwargs['component_type'])
         order_by = 'slug'
         if klass == Group:
             order_by = 'name'
@@ -165,7 +172,7 @@ class ExportComponent(GenericAPIView):
     permission_classes = (permissions.IsAdminUser,)
 
     def get(self, request, slug, *args, **kwargs):
-        klass = klasses[kwargs['component_type']]
+        klass = get_klass_from_component_type(kwargs['component_type'])
         serialisation = get_object_or_404(klass, slug=slug).export_json()
         return Response({'data': serialisation})
 
@@ -177,7 +184,7 @@ class ComponentDependencies(GenericAPIView):
     permission_classes = (permissions.IsAdminUser,)
 
     def get(self, request, slug, *args, **kwargs):
-        klass = klasses[kwargs['component_type']]
+        klass = get_klass_from_component_type(kwargs['component_type'])
         component = get_object_or_404(klass, slug=slug)
 
         def dependency_dict(element):
@@ -191,7 +198,7 @@ component_dependencies = ComponentDependencies.as_view()
 
 
 def component_redirect(request, component_type, slug):
-    klass = klasses[component_type]
+    klass = get_klass_from_component_type(component_type)
     component = get_object_or_404(klass, slug=slug)
 
     if component_type not in klasses or component_type == 'roles':

tests/api/test_applification_api.py

@@ -166,6 +166,9 @@ def test_list(app, admin_user):
         'data': [{'id': group.pk, 'text': 'group1', 'type': 'roles', 'urls': {}, 'uuid': None}]
     }
 
+    # unknown component type
+    app.get('/api/export-import/unknown/', status=404)
+
 
 def test_export_agenda(app, admin_user):
     app.authorization = ('Basic', ('admin', 'admin'))
@@ -196,6 +199,9 @@ def test_export_minor_components(app, admin_user):
     # unknown component
     app.get('/api/export-import/agendas/foo/', status=404)
 
+    # unknown component type
+    app.get('/api/export-import/unknown/foo/', status=404)
+
 
 def test_agenda_dependencies_category(app, admin_user):
     app.authorization = ('Basic', ('admin', 'admin'))
@@ -364,6 +370,11 @@ def test_unknown_compoment_dependencies(app, admin_user):
     app.get('/api/export-import/agendas/foo/dependencies/', status=404)
 
 
+def test_unknown_compoment_type_dependencies(app, admin_user):
+    app.authorization = ('Basic', ('admin', 'admin'))
+    app.get('/api/export-import/unknown/foo/dependencies/', status=404)
+
+
 def test_redirect(app, user):
     app.authorization = ('Basic', ('john', 'doe'))
     agenda = Agenda.objects.create(label='Rdv', slug='rdv', kind='meetings')
@@ -427,6 +438,9 @@ def test_redirect(app, user):
         == f'/manage/unavailability-calendar/{unavailability_calendar.pk}/history/compare/?version1=bar&version2=bar&application=foo'
     )
 
+    # unknown component type
+    app.get('/api/export-import/unknown/foo/redirect/', status=404)
+
 
 def create_bundle(app, admin_user, visible=True, version_number='42.0'):
     app.authorization = ('Basic', ('admin', 'admin'))
@@ -629,7 +643,7 @@ def test_bundle_declare(app, admin_user):
         content_type=ContentType.objects.get_for_model(Agenda),
         object_id=last_page.pk + 1,
     )
-    # and remove agendas to have unkown references in manifest
+    # and remove agendas to have unknown references in manifest
     Agenda.objects.all().delete()
 
     resp = app.put('/api/export-import/bundle-declare/', bundle)