entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

manager: check for correct number of columns in CSV

This commit is contained in:
Frédéric Péters 2016-09-16 15:27:03 +02:00
parent 6290336343
commit 43fd4e736f
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chrono/manager/forms.py
View File

@ -88,7 +88,7 @@ class ImportEventsForm(forms.Form):
for i, csvline in enumerate(csv.reader(content.splitlines(), dialect=dialect)):
if not csvline:
continue
if len(csvline) < 2:
if len(csvline) < 3:
raise ValidationError(_('Invalid file format. (line %d)') % (i+1))
if csvline[0].strip('#') in ('date', 'Date', _('date'), _('Date')):
continue

4
tests/test_manager.py
View File

@ -223,6 +223,10 @@ def test_import_events(app, admin_user):
resp = resp.form.submit(status=200)
assert 'Invalid file format.' in resp.body
resp.form['events_csv_file'] = Upload('t.csv', '2016-14-16,18:00', 'text/csv')
resp = resp.form.submit(status=200)
assert 'Invalid file format.' in resp.body
resp.form['events_csv_file'] = Upload('t.csv', '2016-14-16,18:00,10', 'text/csv')
resp = resp.form.submit(status=200)
assert 'Invalid file format. (date/time format' in resp.body