misc: run tox on tests (#56289)

tests/api/test_datetimes.py

@@ -271,13 +271,13 @@ def test_datetimes_api_user_external_id(app):
 
     resp = app.get('/api/agenda/%s/datetimes/' % agenda.slug, params={'user_external_id': '42'})
     assert resp.json['data'][0]['booked_for_external_user'] == 'main-list'
-    assert resp.json['data'][0]['disabled'] == False
+    assert resp.json['data'][0]['disabled'] is False
 
     resp = app.get(
         '/api/agenda/%s/datetimes/' % agenda.slug,
         params={'user_external_id': '42', 'exclude_user_external_id': '42'},
     )
-    assert resp.json['data'][0]['disabled'] == True
+    assert resp.json['data'][0]['disabled'] is True
 
     booking.in_waiting_list = True
     booking.save()
@@ -1462,19 +1462,13 @@ def test_datetimes_multiple_agendas(app):
 def test_datetimes_multiple_agendas_sort(app):
     first_agenda = Agenda.objects.create(label='First agenda', kind='events')
     Desk.objects.create(agenda=first_agenda, slug='_exceptions_holder')
-    event = Event.objects.create(
-        label='10-05', start_datetime=now().replace(day=10), places=5, agenda=first_agenda
-    )
+    Event.objects.create(label='10-05', start_datetime=now().replace(day=10), places=5, agenda=first_agenda)
     second_agenda = Agenda.objects.create(label='Second agenda', kind='events')
     Desk.objects.create(agenda=second_agenda, slug='_exceptions_holder')
-    event = Event.objects.create(
-        label='09-05', start_datetime=now().replace(day=9), places=5, agenda=second_agenda
-    )
+    Event.objects.create(label='09-05', start_datetime=now().replace(day=9), places=5, agenda=second_agenda)
     third_agenda = Agenda.objects.create(label='Third agenda', kind='events')
     Desk.objects.create(agenda=third_agenda, slug='_exceptions_holder')
-    event = Event.objects.create(
-        label='09-05', start_datetime=now().replace(day=9), places=5, agenda=third_agenda
-    )
+    Event.objects.create(label='09-05', start_datetime=now().replace(day=9), places=5, agenda=third_agenda)
 
     # check events are ordered by start_datetime and then by agenda order in querystring
     agenda_slugs = ','.join((first_agenda.slug, third_agenda.slug, second_agenda.slug))

tests/manager/test_event.py

@@ -1594,7 +1594,6 @@ def test_event_check_all_bookings(app, admin_user):
 
 
 def test_event_check_primary_booking(app, admin_user):
-    group = AbsenceReasonGroup.objects.create(label='Foo bar')
     agenda = Agenda.objects.create(label='Events', kind='events')
     event = Event.objects.create(
         label='xyz',
@@ -1604,7 +1603,7 @@ def test_event_check_primary_booking(app, admin_user):
         agenda=agenda,
     )
     booking = Booking.objects.create(event=event, user_first_name='User', user_last_name='42')
-    booking_2 = Booking.objects.create(event=event, user_first_name='John', user_last_name='Doe')
+    Booking.objects.create(event=event, user_first_name='John', user_last_name='Doe')
     booking_3 = Booking.objects.create(
         event=event, user_first_name='Jane', user_last_name='Doe', in_waiting_list=True
     )

tests/test_agendas.py

@@ -1377,13 +1377,13 @@ def test_agenda_events_duplicate():
     )
     desk = Desk.objects.create(agenda=agenda, slug='_exceptions_holder')
     desk.import_timeperiod_exceptions_from_settings(enable=True)
-    time_period_exception = TimePeriodException.objects.create(
+    TimePeriodException.objects.create(
         desk=desk,
         start_datetime=now(),
         end_datetime=now() + datetime.timedelta(minutes=30),
     )
     assert desk.timeperiodexception_set.count() == 34
-    settings = AgendaNotificationsSettings.objects.create(
+    AgendaNotificationsSettings.objects.create(
         agenda=agenda,
         full_event=AgendaNotificationsSettings.EMAIL_FIELD,
         full_event_emails=['hop@entrouvert.com', 'top@entrouvert.com'],
@@ -1795,8 +1795,8 @@ def test_agenda_reminders_email_content(mailoutbox, freezer):
         assert 'Do no forget ID card.' in body
         assert 'Come !' in body
         assert 'Pricing: 10€' in body
-        assert not 'cancel' in body
-        assert not 'if present' in body  # assert separation with preview code
+        assert 'cancel' not in body
+        assert 'if present' not in body  # assert separation with preview code
     assert 'More information: https://example.party' in mail_bodies[0]
     assert '<a href="https://example.party">More information</a>' in mail_bodies[1]
     mailoutbox.clear()

tox.ini

@@ -33,5 +33,5 @@ commands =
   ./getlasso3.sh
   python3 setup.py compile_translations
   py.test {env:COVERAGE:} {posargs:tests/}
-  pylint: ./pylint.sh chrono/
+  pylint: ./pylint.sh chrono/ tests/
   codestyle: pre-commit run --all-files --show-diff-on-failure