do not save visualization on parameters change (fixes #14644)

bijoe/templates/bijoe/cube.html

@@ -40,7 +40,9 @@
       {% endif %}
 
     {% endfor %}
-    <input type="submit">
+    {% block buttons %}
+      <input type="submit" name="visualize" value="{% trans "Visualiser" %}">
+    {% endblock %}
   </form>
   <div id="data" {% if visualization %}class="visualization-{{visualization.representation}}"{% endif %}>
   {% if visualization %}

bijoe/templates/bijoe/visualization.html

@@ -16,3 +16,8 @@
   <a rel="popup" class="bijoe-button" href="{% url "rename-visualization" pk=object.pk %}">{% trans "Rename" %}</a>
   <a href="{{ iframe_url }}" class="bijoe-button">{% trans "URL for IFRAME" %}</a>
 {% endblock %}
+
+{% block buttons %}
+{{ block.super }}
+<input type="submit" name="save" name="{% trans "Save" %}"/>
+{% endblock %}

bijoe/visualization/views.py

@@ -133,7 +133,9 @@ class VisualizationView(views.AuthorizationMixin, ODSMixin, CubeDisplayMixin,
 
     def get_object(self):
         named_visualization = super(VisualizationView, self).get_object()
-        self.visualization = Visualization.from_json(named_visualization.parameters, request=self.request)
+        if not hasattr(self, 'visualization'):
+            self.visualization = Visualization.from_json(named_visualization.parameters,
+                                                         request=self.request)
         self.cube = self.visualization.cube
         self.warehouse = self.cube.engine
         return named_visualization
@@ -146,7 +148,8 @@ class VisualizationView(views.AuthorizationMixin, ODSMixin, CubeDisplayMixin,
         if form.is_valid():
             self.visualization = Visualization.from_form(self.cube, form)
             named_visualization.parameters = self.visualization.to_json()
-            named_visualization.save()
+            if 'save' in request.POST:
+                named_visualization.save()
         return self.get(request, *args, **kwargs)
 
     def get_context_data(self, **kwargs):