misc: remove update_roles_admins post_migrate (#48372)

src/authentic2/a2_rbac/apps.py

@@ -50,6 +50,3 @@ class Authentic2RBACConfig(AppConfig):
         post_migrate.connect(
             signal_handlers.post_migrate_update_rbac,
             sender=self)
-        post_migrate.connect(
-            signal_handlers.post_migrate_update_role_admins,
-            sender=self)

src/authentic2/a2_rbac/management.py

@@ -151,25 +151,3 @@ def update_content_types_roles():
             ct_admin_role.permissions.add(manage_authorizations_user_perm)
         ct_admin_role.permissions.add(search_ou_perm)
         ct_admin_role.add_child(admin_role)
-
-
-def update_user_admin_roles_permission():
-    role_ct = ContentType.objects.get_for_model(get_role_model())
-    permissions = get_permission_model().objects.filter(target_ct=role_ct, operation__slug=ADMIN_OP.slug)
-    for perm in permissions:
-        administered_role = perm.target
-        admin_role = administered_role.get_admin_role()
-        assert admin_role.slug.startswith('_a2-managers-of-role')
-        new_perm = admin_role.permissions.get(
-            operation__slug=MANAGE_MEMBERS_OP.slug,
-            target_ct=role_ct,
-            target_id=administered_role.id)
-        assert new_perm.ou is None
-        admin_role.delete()
-        assert len(perm.roles.all()) == 1
-        role = perm.roles.first()
-        role.admin_scope_id = new_perm.pk
-        role.save(update_fields=['admin_scope_id'])
-        role.permissions.remove(perm)
-        role.permissions.add(new_perm)
-        assert role.pk == administered_role.get_admin_role(create=False).pk

src/authentic2/a2_rbac/signal_handlers.py

@@ -99,10 +99,3 @@ def create_default_permissions(app_config, verbosity=2, interactive=True, using=
         get_operation(CHANGE_EMAIL_OP)
         get_operation(MANAGE_MEMBERS_OP)
         get_operation(MANAGE_AUTHORIZATIONS_OP)
-
-
-def post_migrate_update_role_admins(app_config, verbosity=2, interactive=True,
-                             using=DEFAULT_DB_ALIAS, **kwargs):
-    from .management import update_user_admin_roles_permission
-    with transaction.atomic():
-        update_user_admin_roles_permission()

tests/test_a2_rbac.py

@@ -502,28 +502,6 @@ def test_unused_account_settings_validation(db, ou1, alert, deletion):
         ou1.full_clean()
 
 
-def test_update_role_admins_perm(transactional_db, simple_user):
-    from django.core.management.sql import emit_post_migrate_signal
-
-    role = Role.objects.create(name='hop')
-    old_admin_role = Role.objects.get_admin_role(
-            role, ou=role.ou,
-            name='Managers of role "{role}"'.format(
-                role=role),
-            slug='_a2-managers-of-role-{role}'.format(
-                role=role),
-            permissions=(get_view_user_perm(),),
-            self_administered=True,
-            update_name=True,
-            update_slug=True,
-            create=True)
-    simple_user.roles.add(old_admin_role)
-
-    emit_post_migrate_signal(verbosity=0, interactive=False, db='default', created_models=[])
-    assert simple_user.get_all_permissions(role) == \
-        {'a2_rbac.manage_members_role', 'a2_rbac.search_role', 'a2_rbac.view_role'}
-
-
 def test_update_content_types_roles(transactional_db, simple_user):
     from django.core.management.sql import emit_post_migrate_signal