entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 32 Releases Activity

manager: forbid sort on role inheritance table member column (#88249)
gitea/authentic/pipeline/head This commit looks good Details

This commit is contained in:
Yann Weber 2024-03-19 10:06:55 +01:00
parent cb751d98f3
commit 891dd6a1de
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/authentic2/manager/tables.py
View File

@ -384,6 +384,7 @@ class InheritanceRolesTable(Table):
'<input class="role-member{% if record.indeterminate %} indeterminate{% endif %}" name="role-{{ record.pk }}" '
'type="checkbox" {% if record.checked %}checked{% endif %}/>',
verbose_name='',
orderable=False,
attrs={'td': {'class': 'member'}},
)

10
tests/test_role_manager.py
View File

@ -513,6 +513,16 @@ def test_role_members_display_role_parents_search(app, superuser, simple_role):
assert 'Managers of role "simple role"' in roles
@pytest.mark.parametrize('url_name', ('a2-manager-role-parents', 'a2-manager-role-children'))
@pytest.mark.parametrize('sortkey', ('name', 'ou', 'members', 'member', 'via'))
def test_role_members_inheritance_order_by(app, superuser, url_name, sortkey):
role = Role.objects.create(name='Foobar', ou=get_default_ou())
url = reverse(url_name, kwargs={'pk': role.pk})
login(app, superuser)
app.get(url, params={'sort': sortkey}) # Simple 200 check (see #88249)
def test_role_members_user_role_mixed_table(app, superuser, settings, simple_role, simple_user):
simple_user.roles.add(simple_role)