entrouvert
/
authentic
16
0
Fork 0
Code Issues Pull Requests 33 Releases Activity

manager: increase click zone of delete icons in tables (#45093)

This commit is contained in:
Frédéric Péters 2020-07-28 21:22:52 +02:00
parent 1a3bd4bb05
commit 3d2b51f444
6 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/authentic2/manager/static/authentic2/manager/css/style.css
View File

@ -66,6 +66,27 @@ table.main.left th {
text-align: left;
}
table.main {
height: 100%;
}
table.main td.remove-icon-column {
padding: 0;
height: 100%;
}
table.main td.remove-icon-column a {
height: 100%;
display: flex;
border: none;
}
table.main td.remove-icon-column a span {
display: block;
margin: auto;
padding: 0 0.5em;
}
table.feeds td.url {
text-align: left;
padding-left: 1em;

6
src/authentic2/manager/static/authentic2/manager/js/manager.js
View File

@ -123,9 +123,9 @@
});
/* user deletion */
$(document).on('click', '.js-remove-object', function (e) {
var $anchor = $(e.target);
if ($(e.target).data('confirm')) {
if (! confirm($(e.target).data('confirm'))) {
var $anchor = $(this);
if ($anchor.data('confirm')) {
if (! confirm($anchor.data('confirm'))) {
return false;
}
}

2
src/authentic2/manager/templates/authentic2/manager/role_members_table.html
View File

@ -7,6 +7,6 @@
<th></th>
{% endblock %}
{% block table.tbody.last.column %}
<td>{% if table.context.view.can_manage_members and row.record.direct %}<a class="icon-remove-sign js-remove-object" data-confirm="{% blocktrans with username=row.record.get_full_name role=table.context.object %}Do you really want to remove user &quot;{{ username }}&quot; from role &quot;{{ role }}&quot;&nbsp;?{% endblocktrans %}" href="#" data-pk-arg="user"></a>{% endif %}</td>
<td class="remove-icon-column">{% if table.context.view.can_manage_members and row.record.direct %}<a class="js-remove-object" data-confirm="{% blocktrans with username=row.record.get_full_name role=table.context.object %}Do you really want to remove user &quot;{{ username }}&quot; from role &quot;{{ role }}&quot;&nbsp;?{% endblocktrans %}" href="#" data-pk-arg="user"><span class="icon-remove-sign"></span></a>{% endif %}</td>
{% endblock %}
{% endif %}

2
src/authentic2/manager/templates/authentic2/manager/role_permissions_table.html
View File

@ -7,6 +7,6 @@
<th></th>
{% endblock %}
{% block table.tbody.last.column %}
<td>{% if table.context.view.can_change %}<a class="icon-remove-sign js-remove-object" href="#" data-pk-arg="permission"></a>{% endif %}</td>
<td class="remove-icon-column">{% if table.context.view.can_change %}<a class="js-remove-object" href="#" data-pk-arg="permission"><span class="icon-remove-sign"></span></a>{% endif %}</td>
{% endblock %}
{% endif %}

2
src/authentic2/manager/templates/authentic2/manager/service_roles_table.html
View File

@ -7,6 +7,6 @@
<th></th>
{% endblock %}
{% block table.tbody.last.column %}
<td>{% if table.context.view.can_change %}<a class="icon-remove-sign js-remove-object" data-confirm="{% blocktrans with name=row.record.name slug=table.context.object %}Do you really want to remove role &quot;{{ name }}&quot; from service &quot;{{ slug }}&quot;&nbsp;?{% endblocktrans %}" href="#" data-pk-arg="role"></a>{% endif %}</td>
<td class="remove-icon-column">{% if table.context.view.can_change %}<a class="js-remove-object" data-confirm="{% blocktrans with name=row.record.name slug=table.context.object %}Do you really want to remove role &quot;{{ name }}&quot; from service &quot;{{ slug }}&quot;&nbsp;?{% endblocktrans %}" href="#" data-pk-arg="role"><span class="icon-remove-sign"></span></a>{% endif %}</td>
{% endblock %}
{% endif %}

4
src/authentic2/manager/templates/authentic2/manager/user_roles_table.html
View File

@ -7,9 +7,9 @@
<th></th>
{% endblock %}
{% block table.tbody.last.column %}
<td>
<td class="remove-icon-column">
{% if table.context.view.can_change and row.record.member %}
<a class="icon-remove-sign {% if not row.record.can_manage_members %} disabled {% else %} js-remove-object {% endif %}" data-confirm="{% blocktrans with name=row.record.name username=table.context.object.get_full_name %}Do you really want to remove role &quot;{{ name }}&quot; from user &quot;{{ username }}&quot;&nbsp;?{% endblocktrans %}" href="#" data-pk-arg="role" title="{% if not row.record.can_manage_members %}{% trans "This role is synchronised from LDAP, changing members is not allowed." %}{% endif %}"></a>
<a class="{% if not row.record.can_manage_members %} disabled {% else %} js-remove-object {% endif %}" data-confirm="{% blocktrans with name=row.record.name username=table.context.object.get_full_name %}Do you really want to remove role &quot;{{ name }}&quot; from user &quot;{{ username }}&quot;&nbsp;?{% endblocktrans %}" href="#" data-pk-arg="role" title="{% if not row.record.can_manage_members %}{% trans "This role is synchronised from LDAP, changing members is not allowed." %}{% endif %}"><span class="icon-remove-sign"></span></a>
{% endif %}
</td>
{% endblock %}