Fix coverity issue about unchecked return

If find_path() does not find MinorVersion, then no value is changed and
we repeate the search with the values for thr major version.
Check if we have found anything and if not set the minor version to 0.

License: MIT
Signed-off-by: Simo Sorce <simo@redhat.com>
This commit is contained in:
Simo Sorce 2014-12-08 17:41:38 -05:00 committed by Benjamin Dauvergne
parent e54e7d3474
commit f9e3d85bf6
1 changed files with 7 additions and 4 deletions

View File

@ -1955,10 +1955,13 @@ lasso_node_impl_get_xmlNode(LassoNode *node, gboolean lasso_dump)
version_snippet);
major_version = *value;
find_path(node, "MinorVersion", &value_node, &version_class, &version_snippet);
value = SNIPPET_STRUCT_MEMBER_P(value_node, G_TYPE_FROM_CLASS(version_class),
version_snippet);
minor_version = *value;
if (find_path(node, "MinorVersion", &value_node, &version_class, &version_snippet) == TRUE) {
value = SNIPPET_STRUCT_MEMBER_P(value_node, G_TYPE_FROM_CLASS(version_class),
version_snippet);
minor_version = *value;
} else {
minor_version = 0;
}
if (strcmp((char*)xmlnode->ns->href, LASSO_LIB_HREF) == 0) {
if (major_version == 1 && minor_version == 0) {