entrouvert
/
lasso
16
0
Fork 0
Code Issues Pull Requests Releases Activity

Do not dereference null pointers 

Sounds like these should all be boolean 'OR's, otherwise,
if profile is not in fact a lasso profile then profile->private_data
will be dereferenced even if it is NULL.
Found by Clang

License: MIT
Signed-off-by: Simo Sorce <simo@redhat.com>
This commit is contained in:
Simo Sorce 2014-06-09 15:29:24 -04:00 committed by Benjamin Dauvergne
parent cb7ea06ca5
commit 1b955021a5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lasso/id-ff/profile.c
View File

@ -559,7 +559,7 @@ static LassoNodeClass *parent_class = NULL;
void
lasso_profile_set_signature_hint(LassoProfile *profile, LassoProfileSignatureHint signature_hint)
{
if (! LASSO_IS_PROFILE(profile) && ! profile->private_data)
if (! LASSO_IS_PROFILE(profile) || ! profile->private_data)
return;
profile->private_data->signature_hint = signature_hint;
}
@ -576,7 +576,7 @@ LassoProfileSignatureHint
lasso_profile_get_signature_hint(LassoProfile *profile)
{
LassoProfileSignatureVerifyHint signature_verify_hint;
if (! LASSO_IS_PROFILE(profile) && ! profile->private_data)
if (! LASSO_IS_PROFILE(profile) || ! profile->private_data)
return LASSO_PROFILE_SIGNATURE_HINT_MAYBE;
signature_verify_hint = profile->private_data->signature_verify_hint;
if (signature_verify_hint >= LASSO_PROFILE_SIGNATURE_VERIFY_HINT_LAST) {
@ -600,7 +600,7 @@ void
lasso_profile_set_signature_verify_hint(LassoProfile *profile,
LassoProfileSignatureVerifyHint signature_verify_hint)
{
if (! LASSO_IS_PROFILE(profile) && ! profile->private_data)
if (! LASSO_IS_PROFILE(profile) || ! profile->private_data)
return;
if (signature_verify_hint >= LASSO_PROFILE_SIGNATURE_VERIFY_HINT_LAST) {
message(G_LOG_LEVEL_WARNING, "%i is an invalid argument for " __FUNCTION__,
@ -622,7 +622,7 @@ lasso_profile_set_signature_verify_hint(LassoProfile *profile,
LassoProfileSignatureVerifyHint
lasso_profile_get_signature_verify_hint(LassoProfile *profile)
{
if (! LASSO_IS_PROFILE(profile) && ! profile->private_data)
if (! LASSO_IS_PROFILE(profile) || ! profile->private_data)
return LASSO_PROFILE_SIGNATURE_HINT_MAYBE;
return profile->private_data->signature_verify_hint;
}