summaryrefslogtreecommitdiffstats
path: root/bindings
diff options
context:
space:
mode:
authorJohn Dennis <jdennis@redhat.com>2015-03-10 21:52:52 (GMT)
committerBenjamin Dauvergne <bdauvergne@entrouvert.com>2015-03-11 08:13:22 (GMT)
commitec73384ccf704096daf9b9151e5c5389e047ec96 (patch)
tree03772a9ce8f8112756b5f65378f3dfec92bc63f6 /bindings
parent236410bf915f09003db735964fdbf7bccb518a99 (diff)
downloadlasso-ec73384ccf704096daf9b9151e5c5389e047ec96.zip
lasso-ec73384ccf704096daf9b9151e5c5389e047ec96.tar.gz
lasso-ec73384ccf704096daf9b9151e5c5389e047ec96.tar.bz2
Add Destination attribute for SAML ECP Response
The Destination attribute on SAML Response element was not being set when handling an ECP response. It is a requirement of SAML 2.0 that signed values contain a Destination attribute on the root element otherwise the client will reject the response. This is documented in the SAML Bindings Specification, Section 3.4.5.2 "Security Considerations": If the message is signed, the Destination XML attribute in the root SAML element of the protocol message MUST contain the URL to which the sender has instructed the user agent to deliver the message. The recipient MUST then verify that the value matches the location at which the message has been received. Normally on login one calls lasso_saml20_login_build_authn_response_msg() which then calls lasso_saml20_profile_build_response_msg() which sets the Destination attribute on the SAML Response. But when doing ECP you do not call lasso_saml20_login_build_authn_response_msg(), instead you call call lasso_saml20_login_build_response_msg() and if it's ECP it then calls lasso_node_export_to_ecp_soap_response(). Thus the ECP response never gets the Destination attribute set because of the different code path, plus for ECP the destination is different, it's the assertion consumer service. FWIW this line of code was copied almost verbatim from lasso_saml20_profile_build_response_msg which also sets the Destination attribute. License: MIT Signed-off-by: John Dennis <jdennis@redhat.com>
Diffstat (limited to 'bindings')
0 files changed, 0 insertions, 0 deletions