entrouvert
/
hobo
16
0
Fork 0
Code Issues Pull Requests 18 Releases Activity

debug: use INTERNAL_IPS.extend to preserve existing values (#65160)

This commit is contained in:
Benjamin Dauvergne 2022-05-12 11:05:20 +02:00
parent 95ee5d21f9
commit 8a7c81561c
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hobo/debug/views.py
View File

@ -34,7 +34,7 @@ class HomeView(FormView):
@cached_property
def debug_ips_variable(self):
return get_setting_variable('INTERNAL_IPS')
return get_setting_variable('INTERNAL_IPS.extend')
def get_initial(self):
initial = super(HomeView, self).get_initial()

12
tests/test_manager.py
View File

@ -127,28 +127,28 @@ def test_debug_home(logged_app):
page = page.form.submit().follow()
assert get_setting_variable('DEBUG_LOG').json is True
assert get_setting_variable('INTERNAL_IPS').json == IP_LIST
assert get_setting_variable('INTERNAL_IPS.extend').json == IP_LIST
hobo_json = get_installed_services_dict()
assert hobo_json['variables']['SETTING_DEBUG_LOG'] is True
assert hobo_json['variables']['SETTING_INTERNAL_IPS'] == IP_LIST
assert hobo_json['variables']['SETTING_INTERNAL_IPS.extend'] == IP_LIST
page.form['debug_log'] = False
page.form['debug_ips'] = ''
page = page.form.submit().follow()
assert get_setting_variable('DEBUG_LOG').json is False
assert get_setting_variable('INTERNAL_IPS').json == []
assert get_setting_variable('INTERNAL_IPS.extend').json == []
hobo_json = get_installed_services_dict()
assert hobo_json['variables']['SETTING_DEBUG_LOG'] is False
assert hobo_json['variables']['SETTING_INTERNAL_IPS'] == []
assert hobo_json['variables']['SETTING_INTERNAL_IPS.extend'] == []
# toggle-current-ip button
page = logged_app.get('/debug/')
page.form['debug_ips'] = IPS
page = page.form.submit(name='toggle-current-ip').follow() # click
assert get_setting_variable('INTERNAL_IPS').json == IP_LIST + ['127.0.0.1']
assert get_setting_variable('INTERNAL_IPS.extend').json == IP_LIST + ['127.0.0.1']
page = page.form.submit(name='toggle-current-ip').follow() # click again
assert get_setting_variable('INTERNAL_IPS').json == IP_LIST
assert get_setting_variable('INTERNAL_IPS.extend').json == IP_LIST
# wrong ips are not returned as a list
page = logged_app.get('/debug/')