entrouvert/wcs
entrouvert
/
wcs
15
1
Fork 0
Code Issues Pull Requests 25 Releases Activity

backoffice: only display datasource custom views to admins (#77191) #299

Merged
fpeters merged 1 commits from wip/77191-custom-views-data-sources-admin into main 2023-05-12 09:39:44 +02:00
Conversation 1 Commits 1 Files Changed 7 +78 -11
fpeters commented 2023-05-09 13:36:45 +02:00
Owner
Copy Link
No description provided.
fpeters force-pushed wip/77191-custom-views-data-sources-admin from 355716c66b to 5a5b3dbd0b 2023-05-09 13:58:56 +02:00 Compare
fpeters force-pushed wip/77191-custom-views-data-sources-admin from 5a5b3dbd0b to 0254c281a9 2023-05-09 14:21:29 +02:00 Compare
fpeters force-pushed wip/77191-custom-views-data-sources-admin from 0254c281a9 to 1232591917 2023-05-09 14:41:47 +02:00 Compare
fpeters changed title from WIP: backoffice: only display datasource custom views to admins (#77191) to backoffice: only display datasource custom views to admins (#77191) 2023-05-09 16:21:21 +02:00
tnoel approved these changes 2023-05-09 17:10:52 +02:00
fpeters force-pushed wip/77191-custom-views-data-sources-admin from 1232591917 to d64cbaf0e0 2023-05-10 07:50:03 +02:00 Compare
fpeters force-pushed wip/77191-custom-views-data-sources-admin from d64cbaf0e0 to 1b8524abe4 2023-05-10 07:53:44 +02:00 Compare
fpeters commented 2023-05-10 07:55:52 +02:00
Author
Owner
Copy Link

En repassant dessus je me disais que ça serait mieux d'avoir la méthode vérifiant si l'agent est admin déplacée vers la classe FormDef et en faisant ça je me suis rendu compte qu'une telle méthode existait déjà, en me disant que je l'avais peut-être raté à cause de son nom je l'ai renommée (s/has_user_access/has_admin_access/).

(une fois jenkins heureux cela vaudra sans doute une nouvelle relecture)

En repassant dessus je me disais que ça serait mieux d'avoir la méthode vérifiant si l'agent est admin déplacée vers la classe FormDef et en faisant ça je me suis rendu compte qu'une telle méthode existait déjà, en me disant que je l'avais peut-être raté à cause de son nom je l'ai renommée (s/has_user_access/has_admin_access/). (une fois jenkins heureux cela vaudra sans doute une nouvelle relecture)
fpeters requested review from tnoel 2023-05-10 08:51:37 +02:00
lguerin approved these changes 2023-05-12 09:26:44 +02:00
fpeters merged commit ee15feb8cf into main 2023-05-12 09:39:44 +02:00
fpeters deleted branch wip/77191-custom-views-data-sources-admin 2023-05-12 09:39:44 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#299
No description provided.
Delete Branch "wip/77191-custom-views-data-sources-admin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?