diff --git a/pylint.rc b/pylint.rc index 0964cfb3e..159f0c281 100644 --- a/pylint.rc +++ b/pylint.rc @@ -55,7 +55,6 @@ disable= too-many-statements, undefined-loop-variable, unnecessary-comprehension, - unnecessary-lambda, unsubscriptable-object, unsupported-membership-test, unused-argument diff --git a/tests/backoffice_pages/test_all.py b/tests/backoffice_pages/test_all.py index 4c7a210f5..da5f26d1f 100644 --- a/tests/backoffice_pages/test_all.py +++ b/tests/backoffice_pages/test_all.py @@ -1699,7 +1699,7 @@ def test_backoffice_multi_actions_oldest_form(pub): assert 'Executing task "Mark as duplicates" on forms' in resp.text assert '>completed<' in resp.text oldest_formdata = None - for i, id in enumerate(sorted(ids, key=lambda x: int(x))): + for i, id in enumerate(sorted(ids, key=int)): if i == 0: oldest_formdata = formdef.data_class().get(id) assert formdef.data_class().get(id).status == 'wf-accepted' @@ -1743,7 +1743,7 @@ def test_backoffice_multi_actions_using_session_user(pub): resp = resp.follow() assert 'Executing task "Show user" on forms' in resp.text assert '>completed<' in resp.text - for id in sorted(ids, key=lambda x: int(x)): + for id in sorted(ids, key=int): content = formdef.data_class().get(id).evolution[-1].parts[0].content assert 'session_user=admin' in content diff --git a/tests/form_pages/test_block.py b/tests/form_pages/test_block.py index 197e3853d..651898288 100644 --- a/tests/form_pages/test_block.py +++ b/tests/form_pages/test_block.py @@ -1265,7 +1265,7 @@ def test_block_with_dynamic_item_field(mock_urlopen, pub, blocks_feature): payload = [{'id': '2', 'text': 'bar'}] return io.StringIO(json.dumps({'data': payload})) - mock_urlopen.side_effect = lambda url: data_source(url) + mock_urlopen.side_effect = data_source FormDef.wipe() BlockDef.wipe() diff --git a/wcs/forms/backoffice.py b/wcs/forms/backoffice.py index 6ac1bd8d0..3e87db1c0 100644 --- a/wcs/forms/backoffice.py +++ b/wcs/forms/backoffice.py @@ -216,7 +216,7 @@ class FormDefUI: item_ids_dict = {x: True for x in item_ids} item_ids = [x for x in ordered_ids if x in item_ids_dict] else: - item_ids.sort(key=lambda x: int(x)) + item_ids.sort(key=int) item_ids.reverse() total_count = len(item_ids) diff --git a/wcs/qommon/form.py b/wcs/qommon/form.py index 717ca276d..ea52a57f3 100644 --- a/wcs/qommon/form.py +++ b/wcs/qommon/form.py @@ -2642,7 +2642,7 @@ $(function() { pwd1 = None PASSWORD_FORMATS = { - 'cleartext': lambda x: force_str(x), + 'cleartext': force_str, 'md5': lambda x: force_str(hashlib.md5(force_bytes(x)).hexdigest()), 'sha1': lambda x: force_str(hashlib.sha1(force_bytes(x)).hexdigest()), }